New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add credential-spec to compose #71

Merged
merged 1 commit into from May 16, 2017

Conversation

Projects
None yet
8 participants
@thaJeztah
Member

thaJeztah commented May 11, 2017

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah May 11, 2017

Member

oh, wait: didn't update the generated spec 😅 - let me do so

Member

thaJeztah commented May 11, 2017

oh, wait: didn't update the generated spec 😅 - let me do so

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah May 11, 2017

Member

Rebased; now looks ok

Member

thaJeztah commented May 11, 2017

Rebased; now looks ok

@friism

This comment has been minimized.

Show comment
Hide comment
@friism

friism May 11, 2017

Contributor
Contributor

friism commented May 11, 2017

add credential-spec to compose
Signed-off-by: Michael Friis <friism@gmail.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
@friism

This comment has been minimized.

Show comment
Hide comment
@friism

friism May 15, 2017

Contributor

thanks @cpuguy83 !!

Contributor

friism commented May 15, 2017

thanks @cpuguy83 !!

@dnephin

LGTM

PR is now a lot of my own code

@mavenugo

This comment has been minimized.

Show comment
Hide comment
@mavenugo

mavenugo May 16, 2017

Contributor

:-) now this PR has 3 authors.

@shin- can you please review/merge this PR if it LGTY ?

Contributor

mavenugo commented May 16, 2017

:-) now this PR has 3 authors.

@shin- can you please review/merge this PR if it LGTY ?

@vdemeester

LGTM 🦁

@dnephin dnephin merged commit 90809f8 into docker:master May 16, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
dco-signed All commits are signed

@thaJeztah thaJeztah deleted the thaJeztah:add-credspec-to-compose branch May 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment