Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests on config/secret indempotence in stack deploy #719

Merged
merged 1 commit into from
Nov 30, 2017

Conversation

vdemeester
Copy link
Collaborator

Related PR : #509

/cc @vieux

Signed-off-by: Vincent Demeester vincent@sbr.pm

@codecov-io
Copy link

codecov-io commented Nov 30, 2017

Codecov Report

Merging #719 into master will increase coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #719      +/-   ##
=========================================
+ Coverage   51.81%     52%   +0.18%     
=========================================
  Files         218     218              
  Lines       17924   17924              
=========================================
+ Hits         9288    9322      +34     
+ Misses       8160    8121      -39     
- Partials      476     481       +5

Related PR : docker#509

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester vdemeester force-pushed the test-secret-config-indempotence branch from 676582e to 5ed399e Compare November 30, 2017 08:45
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vieux vieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vieux vieux merged commit 6b63d7b into docker:master Nov 30, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.12.0 milestone Nov 30, 2017
@vdemeester vdemeester deleted the test-secret-config-indempotence branch November 30, 2017 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants