New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct references to --publish long syntax in docs #746

Merged
merged 1 commit into from Dec 13, 2017

Conversation

Projects
None yet
5 participants
@lachlancooper
Contributor

lachlancooper commented Dec 12, 2017

This fixes the argument names in the long syntax for the --publish, --publish-add, and --publish-rm flags. The correct arguments are published and target, not target and port.

The issue is described in more detail at docker/docker.github.io#5370

@GordonTheTurtle

This comment has been minimized.

Show comment
Hide comment
@GordonTheTurtle

GordonTheTurtle Dec 12, 2017

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "master" git@github.com:lachlancooper/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

GordonTheTurtle commented Dec 12, 2017

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "master" git@github.com:lachlancooper/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Correct references to --publish long syntax in docs
This is the same issue as described at docker/docker.github.io#5370

Signed-off-by: Lachlan Cooper <lachlancooper@gmail.com>

@GordonTheTurtle GordonTheTurtle removed the dco/no label Dec 12, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Dec 12, 2017

Codecov Report

Merging #746 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #746   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files         218      218           
  Lines       14613    14613           
=======================================
  Hits         7811     7811           
  Misses       6321     6321           
  Partials      481      481

codecov-io commented Dec 12, 2017

Codecov Report

Merging #746 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #746   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files         218      218           
  Lines       14613    14613           
=======================================
  Hits         7811     7811           
  Misses       6321     6321           
  Partials      481      481
@mistyhacks

LGTM after you follow the instructions to sign the commit. Sorry, you can't just edit in the Github editor for this repo. Thanks for this!

@thaJeztah

LGTM, thanks!

@thaJeztah thaJeztah merged commit 29ae8cf into docker:master Dec 13, 2017

9 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing eb5e32e...90f44e5
Details
codecov/project 53.45% remains the same compared to eb5e32e
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 18.01.0 milestone Dec 13, 2017

@thaJeztah thaJeztah modified the milestones: 18.01.0, 17.12.0 Dec 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment