Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct references to --publish long syntax in docs #746

Merged
merged 1 commit into from
Dec 13, 2017
Merged

Correct references to --publish long syntax in docs #746

merged 1 commit into from
Dec 13, 2017

Conversation

lachlancooper
Copy link
Contributor

This fixes the argument names in the long syntax for the --publish, --publish-add, and --publish-rm flags. The correct arguments are published and target, not target and port.

The issue is described in more detail at docker/docs#5370

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "master" git@github.com:lachlancooper/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

This is the same issue as described at docker/docs#5370

Signed-off-by: Lachlan Cooper <lachlancooper@gmail.com>
@codecov-io
Copy link

codecov-io commented Dec 12, 2017

Codecov Report

Merging #746 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #746   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files         218      218           
  Lines       14613    14613           
=======================================
  Hits         7811     7811           
  Misses       6321     6321           
  Partials      481      481

Copy link
Contributor

@mdlinville mdlinville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after you follow the instructions to sign the commit. Sorry, you can't just edit in the Github editor for this repo. Thanks for this!

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants