-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct references to --publish long syntax in docs #746
Conversation
Please sign your commits following these rules: $ git clone -b "master" git@github.com:lachlancooper/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f Amending updates the existing PR. You DO NOT need to open a new one. |
This is the same issue as described at docker/docs#5370 Signed-off-by: Lachlan Cooper <lachlancooper@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #746 +/- ##
=======================================
Coverage 53.45% 53.45%
=======================================
Files 218 218
Lines 14613 14613
=======================================
Hits 7811 7811
Misses 6321 6321
Partials 481 481 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after you follow the instructions to sign the commit. Sorry, you can't just edit in the Github editor for this repo. Thanks for this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This fixes the argument names in the long syntax for the
--publish
,--publish-add
, and--publish-rm
flags. The correct arguments arepublished
andtarget
, nottarget
andport
.The issue is described in more detail at docker/docs#5370