Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bash: update trust completions #944

Merged
merged 1 commit into from
Mar 14, 2018

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Mar 14, 2018

(relates to #934 and #935)

The docker trust commands were moved out of experimental, and the docker trust view command was changed to docker trust inspect --pretty.

- How to verify it

Build, and start a dev-container

make -f docker.Makefile binary shell

Start bash, install bash-completion, and load the completion script:

bash
apk add --no-cache bash-completion
. /usr/share/bash-completion/bash_completion
. /go/src/github.com/docker/cli/contrib/completion/bash/docker

Then try completions;

docker tr<tab> i<tab> --p<tab>

which should complete to docker trust inspect --pretty

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah
Copy link
Member Author

ping @vieux @andrewhsu

@@ -4711,11 +4711,25 @@ _docker_tag() {
}


_docker_trust_inspect() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, hold on, this one needs to be moved a couple of lines down

The `docker trust` commands were moved out of experimental,
and the `docker trust view` command was changed to
`docker trust inspect --pretty`.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
case "$cur" in
-*)
COMPREPLY=( $( compgen -W "--help --yes -y" -- "$cur" ) )
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff view on github looks a bit odd here, because the order of commands was changed (they're alphabetical, so order changed due to view -> inspect)

@codecov-io
Copy link

codecov-io commented Mar 14, 2018

Codecov Report

Merging #944 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #944      +/-   ##
==========================================
- Coverage   53.92%   53.92%   -0.01%     
==========================================
  Files         262      262              
  Lines       16604    16604              
==========================================
- Hits         8954     8953       -1     
- Misses       7049     7050       +1     
  Partials      601      601

Copy link
Contributor

@vieux vieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member Author

ping @albers PTAL 🤗

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@vdemeester vdemeester merged commit 6d7c23a into docker:master Mar 14, 2018
@GordonTheTurtle GordonTheTurtle added this to the 18.04.0 milestone Mar 14, 2018
@thaJeztah thaJeztah deleted the update-completion-scripts branch March 14, 2018 08:50
@thaJeztah
Copy link
Member Author

Sorry for not waiting for you @albers - this had to go into the 18.03 release; let me know if there's things to address in this change

@thaJeztah thaJeztah modified the milestones: 18.04.0, 18.03.0 Mar 14, 2018
@albers
Copy link
Collaborator

albers commented Mar 14, 2018 via email

@thaJeztah
Copy link
Member Author

Thanks! You’re the best

@albers
Copy link
Collaborator

albers commented Mar 17, 2018

LGTM

@thaJeztah
Copy link
Member Author

Thanks for reviewing 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants