Skip to content

Commit

Permalink
Update flaky tests on inter-service dependencies
Browse files Browse the repository at this point in the history
Signed-off-by: Anca Iordache <anca.iordache@docker.com>
  • Loading branch information
aiordache committed Apr 15, 2021
1 parent adae403 commit 1b42ecb
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions tests/integration/project_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -1955,12 +1955,10 @@ def test_project_up_completed_unsuccessfully_dependency(self):
with pytest.raises(ProjectError):
project.up()

containers = project.containers()
assert len(containers) == 0

svc1 = project.get_service('svc1')
svc2 = project.get_service('svc2')
assert 'svc1' in svc2.get_dependency_names()
assert len(svc2.containers()) == 0
with pytest.raises(CompletedUnsuccessfully):
svc1.is_completed_successfully()

Expand Down Expand Up @@ -1993,14 +1991,12 @@ def test_project_up_completed_differently_dependencies(self):
with pytest.raises(ProjectError):
project.up()

containers = project.containers()
assert len(containers) == 0

svc1 = project.get_service('svc1')
svc2 = project.get_service('svc2')
svc3 = project.get_service('svc3')
assert ['svc1', 'svc2'] == svc3.get_dependency_names()
assert svc1.is_completed_successfully()
assert len(svc3.containers()) == 0
with pytest.raises(CompletedUnsuccessfully):
svc2.is_completed_successfully()

Expand Down

0 comments on commit 1b42ecb

Please sign in to comment.