Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit build concurrency according to --parallel #10133

Merged
merged 2 commits into from
Jan 5, 2023

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Jan 3, 2023

What I did
This run the image build process on a per-service basis with concurrency constrained according to --parallel flag

Related issue
closes #9091

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@ndeloof ndeloof requested review from a team, nicksieger, StefanScherer, ulyssessouza, glours, milas and laurazard and removed request for a team January 3, 2023 09:14
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 73.89% // Head: 74.26% // Increases project coverage by +0.36% 🎉

Coverage data is based on head (aa5cdf2) compared to base (dcbd68a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10133      +/-   ##
==========================================
+ Coverage   73.89%   74.26%   +0.36%     
==========================================
  Files           2        2              
  Lines         272      272              
==========================================
+ Hits          201      202       +1     
+ Misses         60       59       -1     
  Partials       11       11              
Impacted Files Coverage Δ
pkg/e2e/framework.go 72.54% <0.00%> (+0.39%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@glours glours merged commit f6f29a4 into docker:v2 Jan 5, 2023
@ndeloof ndeloof deleted the build_concurrency branch December 20, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants