-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: merge Go coverage reports before upload #10666
Conversation
nice! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ho yeah!! Thanks @milas
06eb3c9
to
eb331b9
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10666 +/- ##
==========================================
+ Coverage 59.70% 59.71% +0.01%
==========================================
Files 107 107
Lines 9515 9515
==========================================
+ Hits 5681 5682 +1
+ Misses 3253 3252 -1
Partials 581 581 ☔ View full report in Codecov by Sentry. |
Attempting to fix the state of codecov action checks right now, which are behaving very erratically. Using the new functionality in Go 1.20 to merge multiple reports, so now the unit & E2E coverage data reports are stored as artifacts and then downloaded, merged, and finally uploaded to codecov as a new job. Additionally, add a `codecov.yml` config and try to turn down the aggressiveness of it for CI checks. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
What I did
Attempt to fix the state of codecov action checks right now, which are behaving very erratically.
Using the new functionality in Go 1.20 to merge multiple reports, so now the unit & E2E coverage data reports are stored as artifacts and then downloaded, merged, and finally uploaded to codecov as a new job.
(not mandatory) A picture of a cute animal, if possible in relation to what you did
![starfish](https://private-user-images.githubusercontent.com/841263/244100791-d6f1ada5-0a32-4e1c-8648-b6160c487ae5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUyODQ5OTAsIm5iZiI6MTcyNTI4NDY5MCwicGF0aCI6Ii84NDEyNjMvMjQ0MTAwNzkxLWQ2ZjFhZGE1LTBhMzItNGUxYy04NjQ4LWI2MTYwYzQ4N2FlNS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTAyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkwMlQxMzQ0NTBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xYTdmN2M4Y2Q2N2E0MTc2ZTJhOGNiY2YxNzM2MTE4YjIwMTFkYzMxOGU3NjA5YjAxYmY4ZGY1YTM1ZTU1YWU2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.8d-YcABIf72MecSF-GWHsue2UvvUxRDbZFX797mUU5w)