Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render quiet after filtering applied #11177

Merged
merged 1 commit into from Nov 15, 2023
Merged

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Nov 10, 2023

What I did
render in quiet mode after applying filter

Related issue
closes #11176

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@ndeloof ndeloof requested review from a team, nicksieger, StefanScherer, ulyssessouza, glours, milas and laurazard and removed request for a team November 10, 2023 13:00
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (254a94b) 56.84% compared to head (8de7aae) 56.77%.

❗ Current head 8de7aae differs from pull request most recent head 2306f8e. Consider uploading reports for the commit 2306f8e to get more accurate results

Files Patch % Lines
cmd/compose/list.go 0.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11177      +/-   ##
==========================================
- Coverage   56.84%   56.77%   -0.08%     
==========================================
  Files         133      133              
  Lines       11427    11370      -57     
==========================================
- Hits         6496     6455      -41     
+ Misses       4297     4286      -11     
+ Partials      634      629       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me

@ndeloof ndeloof merged commit c169436 into docker:main Nov 15, 2023
24 checks passed
@ndeloof ndeloof deleted the quiet_filtered branch November 15, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] The --quiet option to the docker compose ls command seems to ignore the --filter option
2 participants