WIP fix tracing #11846
Closed
WIP fix tracing #11846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
ndeloof
reviewed
May 23, 2024
| tracingShutdown, err := tracing.InitTracing(dockerCli) | ||
| if err != nil { | ||
| return fmt.Errorf("initializing tracing: %w", err) | ||
| } | ||
|
|
||
| ctx := cmd.Context() | ||
| ctx, cmdSpan := tracing.Tracer.Start( | ||
| ctx, cmdSpan := tracing.TracingProvider.Tracer("compose").Start( |
There was a problem hiding this comment.
must not set Tracer name to "compose"
// The passed name needs to uniquely identify instrumentation code.
// Therefore, it is recommended that name is the Go package name of the
// library providing instrumentation (note: not the code being
// instrumented)
yes, this is crazy and terribly confusing, instrumented code is identified by service.name attribute, ... which we set in compose to track compose service name 😓, need to be fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did