New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for log-driver as a docker-compose.yml option #1388
Conversation
@@ -271,6 +271,16 @@ labels: | |||
- "com.example.label-with-empty-value" | |||
``` | |||
|
|||
### log drivers | |||
|
|||
Set the log driver to use for the container, same as the ``--log-driver=""`` option of ``docker run``. The possible value are currently : ``json-file``, ``syslog`` and ``none``. This list will elvolve with the addition of the driver support in the driver engine. The default value is the same as for docker, it is ``json-file``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reads a bit confusingly. How about:
Specify a logging driver for the service's containers, as with the
--log-driver
option fordocker run
(documented here).Allowed values are currently
json-file
,syslog
andnone
. The list will change over time as more drivers are added to the Docker engine.The default value is
json-file
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The header for this section should read "log_driver" too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sounds way better :) I'll update it according to it.
Thanks! Minor documentation comments; otherwise, looks great. |
Closes docker#1303 Signed-off-by: Vincent Demeester <vincent@sbr.pm>
1e186cc
to
f626fc5
Compare
@aanand took care of your comments ;) |
Thanks! LGTM |
LGTM |
Add support for log-driver as a docker-compose.yml option
Is |
@nick-allen |
From what I can tell, this does not cover setting |
@flower-pot it's probably already there #1665 (for the next release 1.4.0) |
Discussed in #1303, as
docker-py
version 1.2.1 support this, we can add it as an option fordocker-compose.yml
files.It's kept simple for now, the config files would look like :
The choice of
log_driver
is to keep it coherent with the--log-driver
option ofdocker run
(even though it'sLogConfig
in the API).Signed-off-by: Vincent Demeester vincent@sbr.pm