Support `--log-driver`

[colinrymer]

Docker 1.6 adds support for the --log-driver option. It'd be great to be able to set this in the docker-compose.yml file.

[chernjie]

+1

just bump into this problem

[rozbb]

+1
Looks like compose and docker-py will have to be updated to support the --log-driver

[pavlo]

+1

[cmoro-deusto]

Just upgraded to docker v1.6 and happily migrated all my oldishe bash start/stop scripts to compose only to find that --log-driver is not yet supported. This would be great.

If you need help beta testing this just let me know.

Thanks a lot for you awesome work!

[styleex]

+1

[chernjie]

keeping a watch out for docker/docker-py#547

[cmoro-deusto]

thanks @chernjie

[lwcolton]

It looks like docker/docker-py#547 has been resolved. +1 to adding log driver support to docker compose.

[cyppan]

+1

[strootman]

+1

[saschaarthur]

well im ultra bad at python i tried to start with:

diff --git a/compose/config.py b/compose/config.py
index d54215d..4ef1f51 100644
--- a/compose/config.py
+++ b/compose/config.py
@@ -21,6 +21,7 @@ DOCKER_CONFIG_KEYS = [
     'image',
     'labels',
     'links',
+    'log_config',
     'mem_limit',
     'net',
     'pid',
diff --git a/compose/service.py b/compose/service.py
index c663448..a1ed317 100644
--- a/compose/service.py
+++ b/compose/service.py
@@ -23,8 +23,9 @@ DOCKER_START_KEYS = [
     'dns',
     'dns_search',
     'env_file',
-    'extra_hosts',
+    'extra_hosts',
     'net',
+    'log_config',
     'pid',
     'privileged',
     'restart',
@@ -430,6 +431,7 @@ class Service(object):
         cap_add = options.get('cap_add', None)
         cap_drop = options.get('cap_drop', None)
         pid = options.get('pid', None)
+       log_config = options.get('log_config', None)

         dns = options.get('dns', None)
         if isinstance(dns, six.string_types):
@@ -455,6 +457,7 @@ class Service(object):
             restart_policy=restart,
             cap_add=cap_add,
             cap_drop=cap_drop,
+           log_config=log_config,
             extra_hosts=extra_hosts,
             pid_mode=pid

now compose accepts "log-driver" argument in *.yml but it there are still issues with the logger

here:
https://github.com/docker/docker-py/blob/master/docker/utils/utils.py#L467

heres a stacktrace im out of knowledge, since i dont know how to initiate the logger

Traceback (most recent call last):
  File "/usr/local/bin/docker-compose", line 9, in <module>
    load_entry_point('docker-compose==1.3.0dev', 'console_scripts', 'docker-compose')()
  File "/usr/local/lib/python2.7/dist-packages/docker_compose-1.3.0dev-py2.7.egg/compose/cli/main.py", line 31, in main
    command.sys_dispatch()
  File "/usr/local/lib/python2.7/dist-packages/docker_compose-1.3.0dev-py2.7.egg/compose/cli/docopt_command.py", line 21, in sys_dispatch
    self.dispatch(sys.argv[1:], None)
  File "/usr/local/lib/python2.7/dist-packages/docker_compose-1.3.0dev-py2.7.egg/compose/cli/command.py", line 34, in dispatch
    super(Command, self).dispatch(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/docker_compose-1.3.0dev-py2.7.egg/compose/cli/docopt_command.py", line 24, in dispatch
    self.perform_command(*self.parse(argv, global_options))
  File "/usr/local/lib/python2.7/dist-packages/docker_compose-1.3.0dev-py2.7.egg/compose/cli/command.py", line 66, in perform_command
    handler(project, command_options)
  File "/usr/local/lib/python2.7/dist-packages/docker_compose-1.3.0dev-py2.7.egg/compose/cli/main.py", line 467, in up
    do_build=not options['--no-build'],
  File "/usr/local/lib/python2.7/dist-packages/docker_compose-1.3.0dev-py2.7.egg/compose/project.py", line 208, in up
    do_build=do_build):
  File "/usr/local/lib/python2.7/dist-packages/docker_compose-1.3.0dev-py2.7.egg/compose/service.py", line 213, in recreate_containers
    **override_options)
  File "/usr/local/lib/python2.7/dist-packages/docker_compose-1.3.0dev-py2.7.egg/compose/service.py", line 186, in create_container
    intermediate_container=intermediate_container,
  File "/usr/local/lib/python2.7/dist-packages/docker_compose-1.3.0dev-py2.7.egg/compose/service.py", line 418, in _get_container_create_options
    container_options['host_config'] = self._get_container_host_config(override_options, one_off=one_off, intermediate_container=intermediate_container)
  File "/usr/local/lib/python2.7/dist-packages/docker_compose-1.3.0dev-py2.7.egg/compose/service.py", line 464, in _get_container_host_config
    pid_mode=pid
  File "/usr/local/lib/python2.7/dist-packages/docker/utils/utils.py", line 472, in create_host_config
    ' found {0}'.format(type(log_config))
docker.errors.DockerException: Invalid type for log_config param: expected LogConfig but found <type 'str'>

[vdemeester]

@saschaarthur This would look like this : vdemeester@e324022

I'm looking at how to test it (unit & integration tests)

[vdemeester]

The other questions is : With --log-driver it's possible to pass out config (with a set of key/value). How would it translate in a docker-compose.yml file. Something like that would do ?

web:
    image: busybox
    log_config: 
        type: json-file
        configs:
            - key1: val1
            - key2: val2

[rozbb]

That looks almost right. I think it should be config instead of configs. I'm basing this on a cursory look at the source for LogConfig. Good job!

web:
  image: busybox
  log_config:
    type: json-file
    config:
      - key1: val1
      - key2: val2

[vdemeester]

@doomrobo ah yeah, agree.

Something is weird, I don't see an option in the docker run command to set the config keys/values. I know --logging-opt for the daemon but I don't see it for the run. You definitely can set it via the API though but not via the CLI.. I'm gonna take a look at the docker source code to see how it is used.

Also, the flag is --log-driver, we might want to use the same term instead of log_config ?