Fix for #1503 #1504
Closed
Fix for #1503 #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- inject container name at creation in environment variables when available. The variable is name COMPOSE_CONTAINER_NAME Signed-off-by: Pierre Baillet <pierre@baillet.name>
|
+1 |
|
In the next release of docker and compose there will be support for network aliases backed by an embedded DNS server. This should allow you to query for the name of a container from dns instead of passing it in. I think querying for the name is a more reliable solution because if the container name changes, you'll get the new name. With an environment variable you'd get the old name. Thanks for the PR, but I don't think we'll be able to accept it at this time, so I'm going to close it. |
|
np, I've had ample time to find solutions to this problem since last June. |
Could you please mention the solutions you have found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(too naive ?) Fix for #1503
available. The variable is name COMPOSE_CONTAINER_NAME