Remove useless postgres 'port' configuration #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d2bit
force-pushed
the
clean-rails-quickstart-guide-db-config
branch
from
6e0978c
to
1a9ddf6
Compare
Signed-off-by: David BF <burretfresket@gmail.com>
|
I think this is a holdover from before the LGTM |
|
LGTM |
dnephin
added a commit
that referenced
this pull request
Jul 31, 2015
…onfig Remove useless postgres 'port' configuration
aanand
pushed a commit
to aanand/fig
that referenced
this pull request
Jul 31, 2015
…e-db-config Remove useless postgres 'port' configuration (cherry picked from commit b25f05b) Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I'm not wrong
portsshould beexpose, but the image is already exposing that port, so it could be cleaned.I've seen it's already done in Djanjo version.
BTW, why could be the reason to use
portswithout setting the host port number up? I really don't get that option 😕Really nice work in composer, I like it so much!!