Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception for networkname in windows networking #5050

Merged
merged 1 commit into from
Jul 25, 2017
Merged

Add exception for networkname in windows networking #5050

merged 1 commit into from
Jul 25, 2017

Conversation

kirinrastogi
Copy link

@kirinrastogi kirinrastogi commented Jul 25, 2017

Similar to #4794

Fixes:
ERROR: Network "musicstore_default" needs to be recreated - option "com.docker.network.windowsshim.networkname" has changed

docker_networkname

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "kirin-network-options" git@github.com:kirinrastogi/compose.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: Kirin Rastogi <kirin.Rastogi@avg.com>
Signed-off-by: Kirin Rastogi <rastogikirin@gmail.com>
@shin- shin- added the kind/bug label Jul 25, 2017
@shin- shin- added this to the 1.15.0 milestone Jul 25, 2017
@shin-
Copy link

shin- commented Jul 25, 2017

Thank you!

@shin- shin- merged commit 103f796 into docker:master Jul 25, 2017
@shin-
Copy link

shin- commented Jul 25, 2017

@friism Do you know if there is a way we could get some advance warning when the Windows Engine team adds these, so we can update the whitelist before it becomes a problem?

@friism
Copy link

friism commented Jul 25, 2017

@kallie-b do you know if you're going to be adding more of these hard-coded networks? It would be good to get a heads-up if you do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants