New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support interactive in yml configuration #566

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@tsaikd

tsaikd commented Oct 21, 2014

Sometimes the docker image will run service in background and enter bash, if not setup stdin_open and tty flag, the container can not enter bash interactive mode to idle.

support interactive in config yml
Signed-off-by: tsaikd <tsaikd@gmail.com>
@aanand

This comment has been minimized.

Show comment
Hide comment
@aanand

aanand Aug 13, 2015

Contributor

Thanks for the contribution!

I'm not sure it makes sense to set stdin_open on a container that'll be run with docker-compose up. We can't hook up the terminal's stdin because there may be multiple containers running - which one would we attach to?

If you still feel you need this feature, could you open an issue describing the use case, and why Compose doesn't currently serve it?

Contributor

aanand commented Aug 13, 2015

Thanks for the contribution!

I'm not sure it makes sense to set stdin_open on a container that'll be run with docker-compose up. We can't hook up the terminal's stdin because there may be multiple containers running - which one would we attach to?

If you still feel you need this feature, could you open an issue describing the use case, and why Compose doesn't currently serve it?

@aanand aanand closed this Aug 13, 2015

@tsaikd

This comment has been minimized.

Show comment
Hide comment
@tsaikd

tsaikd Aug 13, 2015

The PR was created when docker without exec method for entering the running container.
It's not necessary now.

tsaikd commented Aug 13, 2015

The PR was created when docker without exec method for entering the running container.
It's not necessary now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment