Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag as x.y.z without v prefix #7177

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Tag as x.y.z without v prefix #7177

merged 1 commit into from
Jan 23, 2020

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Jan 22, 2020

Resolves #7168

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

Close #7168
@thaJeztah
Copy link
Member

Should we keep this PR for the next release, and for the current one just manually push a tag using the same commit (698e284) ?

@ndeloof
Copy link
Contributor Author

ndeloof commented Jan 22, 2020

afaik adding a tag won't create an alias for the release download URL.

@thaJeztah
Copy link
Member

right, but after tagging, we can create a new release and upload the same binaries there?

Copy link
Contributor

@ulyssessouza ulyssessouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulyssessouza ulyssessouza merged commit ec0f8a8 into master Jan 23, 2020
@thaJeztah thaJeztah deleted the ndeloof-patch-1 branch January 23, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest release tagged with 'v'
3 participants