Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore missing version commands #8738

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Conversation

Shikachuu
Copy link

@Shikachuu Shikachuu commented Oct 3, 2021

What I did

  • Removed the hidden flag from the version command, since by default and for historical reasons aswell it shouldn't be hidden.
  • Since the documentation for the v2 still constantly reffering to a --version flag on the root command, I added it aswell.
    (This is up for a discuisson, since I think this change shouldn't be exist and we have to correct the documentation.)
    (If we are still planning to keep this change, I think it could be done more elegantly.
    I did it aswell, since I forgot that the old python version also handle the -v flag next to --version)

Related issue
Fix #8729

A picture of a cute animal, if possible in relation with what you did
(A hiding cat, reffering to the hidden version command.)
hidden_cat

@ndeloof
Copy link
Contributor

ndeloof commented Oct 3, 2021

Removed the hidden flag from the version command

:+1, I didn't noticed we kept this one hidden, this was a mistake

Since the documentation for the v2 still constantly reffering to a --version flag on the root command

I'm fine we introduce --version as this as low impact but documentation should be fixed as well.
Maybe this flag should be mark hidden so we encourage use of the explicit version command?

@Shikachuu
Copy link
Author

Removed the hidden flag from the version command

:+1, I didn't noticed we kept this one hidden, this was a mistake

Since the documentation for the v2 still constantly reffering to a --version flag on the root command

I'm fine we introduce --version as this as low impact but documentation should be fixed as well. Maybe this flag should be mark hidden so we encourage use of the explicit version command?

I think hiding this would be a nice idea, I'll add the change soon.
Besides that, everything else looks okay?

cmd/compose/compose.go Outdated Show resolved Hide resolved
@ndeloof
Copy link
Contributor

ndeloof commented Oct 4, 2021

All good for me
Some of your commits are not signed-off. Maybe you could also squash all of them into a single one

Copy link
Member

@mat007 mat007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

…root command.

Signed-off-by: Shikachuu <zcmate@gmail.com>
@Shikachuu
Copy link
Author

Thanks for the reviews!
Sorry I hade to do some acrobatic manovers with rebase, but now all commits squashed to one and signed-off. 😆

@ndeloof ndeloof merged commit fc8a433 into docker:v2 Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker-compose v2.0.1 Missing "version" in --help
3 participants