Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent flickering prompt when pulling same image from N services #9476

Merged
merged 1 commit into from
May 20, 2022

Conversation

maxcleme
Copy link
Member

Signed-off-by: Maxime CLEMENT maxime.clement@docker.com

What I did

Prevent event's parent to be swapped for another, since it uses the same ID it would make the prompt to flicker.

Current issue can be seen by using the following compose file :

services:
  a:
    image: ubuntu:22.10
  b:
    image: ubuntu:22.10

Note: Use both same large images to make the issue appear longer

Related issue

Fixes #9469

(not mandatory) A picture of a cute animal, if possible in relation with what you did

Signed-off-by: Maxime CLEMENT <maxime.clement@docker.com>
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mess output when compose pull images that contains the same layer
3 participants