Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't wait for disabled dependency #9759

Merged
merged 2 commits into from Aug 17, 2022
Merged

Conversation

nicksieger
Copy link
Member

What I did

Check but don't wait for disabled dependency.

  • create: pull all services logic out of loop; add DependsOn deps
  • up/start/run: don't wait for disabled service

Related issue

Fixes #9591.

(not mandatory) A picture of a cute animal, if possible in relation with what you did

Parrots

Signed-off-by: Nick Sieger <nick@nicksieger.com>
Signed-off-by: Nick Sieger <nick@nicksieger.com>
@nicksieger nicksieger requested a review from a team August 17, 2022 17:36
Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicksieger nicksieger merged commit a64a5a6 into docker:v2 Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants