map deploy.restart_policy.condition to engine values #9944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glours
requested review from
nicksieger,
ndeloof,
StefanScherer,
ulyssessouza,
milas and
laurazard
and removed request for
a team
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
glours
force-pushed
the
map-spec-restart-policy-to-engine
branch
from
95ab33e
to
eaf27d9
Compare
milas
approved these changes
Oct 24, 2022
laurazard
approved these changes
Oct 24, 2022
|
Both
I imagine something has gone wrong in this commit. |
|
@i3130002 this commit has not been released, so if you want to test it you should build Compose by yourself for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guillaume Lours 705411+glours@users.noreply.github.com
What I did
Map the value of
deploy.restat_policy.conditionto values supported by the engine. Basically this mapnonetonoandanytoalwaysRelated issue
fixes #8756
docker/docs#15936
(not mandatory) A picture of a cute animal, if possible in relation with what you did
