Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow clients to request specific manifest media types #2402

Merged
merged 1 commit into from
Oct 11, 2017

Conversation

smarterclayton
Copy link
Contributor

The current registry/client sends the registered manifest types in
random order. Allow clients to request a single specific manifest type
or a preferred order as per the HTTP spec.

Fixes #2385

Signed-off-by: Clayton Coleman ccoleman@redhat.com

@u2takey u2takey mentioned this pull request Sep 20, 2017
@stevvooe
Copy link
Collaborator

LGTM

@codecov
Copy link

codecov bot commented Oct 3, 2017

Codecov Report

Merging #2402 into master will decrease coverage by 9.54%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2402      +/-   ##
==========================================
- Coverage   60.28%   50.74%   -9.55%     
==========================================
  Files         126      126              
  Lines       14424    14436      +12     
==========================================
- Hits         8696     7325    -1371     
- Misses       4843     6367    +1524     
+ Partials      885      744     -141
Impacted Files Coverage Δ
registry/client/repository.go 56.22% <100%> (+1%) ⬆️
registry.go 33.33% <40%> (+4.76%) ⬆️
registry/storage/driver/gcs/gcs.go 0.32% <0%> (-66.13%) ⬇️
registry/storage/driver/oss/oss.go 0.45% <0%> (-56.5%) ⬇️
registry/storage/driver/s3-aws/s3.go 4.07% <0%> (-55.4%) ⬇️
registry/storage/driver/s3-goamz/s3.go 0.4% <0%> (-52.4%) ⬇️
registry/client/transport/transport.go 68.75% <0%> (-8.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb49a16...3c5f85a. Read the comment docs.

@stevvooe
Copy link
Collaborator

stevvooe commented Oct 3, 2017

@smarterclayton Could you please rebase this? There was a fix in master to deal with some upstream changes to golint.

The current registry/client sends the registered manifest types in
random order. Allow clients to request a single specific manifest type
or a preferred order as per the HTTP spec.

Signed-off-by: Clayton Coleman <ccoleman@redhat.com>
@smarterclayton
Copy link
Contributor Author

Updated

@stevvooe
Copy link
Collaborator

stevvooe commented Oct 4, 2017

@dmcgowan PTAL

Copy link
Collaborator

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 7484e51 into distribution:master Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants