Remove container after run. #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
reviewed
Nov 17, 2020
| @@ -40,7 +40,7 @@ Some examples are: | |||
| binaries. | |||
|
|
|||
| ```sh | |||
| docker run -it --net host --pid host --userns host --cap-add audit_control \ | |||
There was a problem hiding this comment.
Perhaps the -it was added to allow stopping the container with CTRL-C (not sure, but it's common)
There was a problem hiding this comment.
just tested, it can be stopped even without -it using CTRL-C
There was a problem hiding this comment.
👍 thanks! saw your PR in my notifications, and thought it was worth mentioning; thanks for checking!
|
Closes #452 |
|
Thanks @Constantin07 for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just updating README.md.
Added
--rmflag to remove container after run as probably not required for dangling ones to be left (no need to clean up afterwards).Also,
-itflag is not necessary for running checks because interactive shell is not used.