Skip to content

Commit

Permalink
Merge pull request #257 from seemethere/sock_puppets
Browse files Browse the repository at this point in the history
Add the docker.socket back in
  • Loading branch information
seemethere committed Nov 15, 2018
2 parents c7d626d + 69bd2ee commit 114582c
Show file tree
Hide file tree
Showing 5 changed files with 31 additions and 2 deletions.
10 changes: 9 additions & 1 deletion deb/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ RUN=docker run --rm -i \
-v $(CURDIR)/debbuild/$@:/build \
debbuild-$@/$(ARCH)

SOURCE_FILES=engine-image cli.tgz docker.service distribution_based_engine.json
SOURCE_FILES=engine-image cli.tgz docker.service docker.socket 00-socket-activation.conf distribution_based_engine.json
SOURCES=$(addprefix sources/, $(SOURCE_FILES))

.PHONY: help
Expand Down Expand Up @@ -117,6 +117,14 @@ sources/docker.service: ../systemd/docker.service
mkdir -p $(@D)
cp $< $@

sources/docker.socket: ../systemd/docker.socket
mkdir -p $(@D)
cp $< $@

sources/00-socket-activation.conf: ../systemd/00-socket-activation.conf
mkdir -p $(@D)
cp $< $@

sources/distribution_based_engine.json: sources/engine-image
mkdir -p $(@D)
docker inspect "$(shell cat $<)" \
Expand Down
2 changes: 2 additions & 0 deletions deb/common/rules
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ override_dh_auto_install:
install -D -m 0755 /go/src/github.com/docker/cli/build/docker debian/docker-ce-cli/usr/bin/docker
# docker-ce install
install -D -m 0644 /sources/docker.service debian/docker-ce/lib/systemd/system/docker.service
install -D -m 0644 /sources/docker.socket debian/docker-ce/lib/systemd/system/docker.socket
install -D -m 0644 /sources/00-socket-activation.conf debian/docker-ce/lib/systemd/system/docker.service.d/00-socket-activation.conf
install -D -m 0755 /source/dockerd debian/docker-ce/usr/bin/dockerd-ce
install -D -m 0755 /source/docker-proxy debian/docker-ce/usr/bin/docker-proxy
install -D -m 0755 /source/docker-init debian/docker-ce/usr/bin/docker-init
Expand Down
7 changes: 7 additions & 0 deletions systemd/00-socket-activation.conf
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
[Unit]
After=docker.socket
Requires=docker.socket

[Service]
ExecStart=
ExecStart=/usr/bin/dockerd -H fd://
2 changes: 1 addition & 1 deletion systemd/docker.service
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Type=notify
# the default is not to use systemd for cgroups because the delegate issues still
# exists and systemd currently does not support the cgroup feature set required
# for containers run by docker
ExecStart=/usr/bin/dockerd -H unix://
ExecStart=/usr/bin/dockerd
ExecReload=/bin/kill -s HUP $MAINPID
TimeoutSec=0
RestartSec=2
Expand Down
12 changes: 12 additions & 0 deletions systemd/docker.socket
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
[Unit]
Description=Docker Socket for the API
PartOf=docker.service

[Socket]
ListenStream=/var/run/docker.sock
SocketMode=0660
SocketUser=root
SocketGroup=docker

[Install]
WantedBy=sockets.target

0 comments on commit 114582c

Please sign in to comment.