-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master] plugins: don't require "experimental" for buildx #490
[master] plugins: don't require "experimental" for buildx #490
Conversation
Some features of buildx may still be "experimental" / non-final, but we can call those out individually if needed. This change removes the requirement to enable "experimental" mode in the cli configuration file, so that it's easier for users to try buildx. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We should update the buildx README too
Somewhat related, any thoughts about |
Still being discussed; we may remove the "experimental" requirement itself, but there's still (UX) issues with those subcommands that should be looked into, so they may still be marked "experimental" (in the documentation), to indicate that backward-compatibility of the commands is not guaranteed. |
@chris-crone yes, I had that one open in a tab; should be updated that starting with 20.x it's not needed to set the configuration (unless we decide to backport this change to 19.03, in which case the patch release version should be mentioned) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
since docker 20.10 buildx is no longer experimental see docker/docker-ce-packaging#490
Some features of buildx may still be "experimental" / non-final, but we can call those out individually if needed.
This change removes the requirement to enable "experimental" mode in the cli configuration file, so that it's easier for users to try buildx.