Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] plugins: don't require "experimental" for buildx #490

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

thaJeztah
Copy link
Member

Some features of buildx may still be "experimental" / non-final, but we can call those out individually if needed.

This change removes the requirement to enable "experimental" mode in the cli configuration file, so that it's easier for users to try buildx.

Some features of buildx may still be "experimental" / non-final,
but we can call those out individually if needed.

This change removes the requirement to enable "experimental" mode
in the cli configuration file, so that it's easier for users to
try buildx.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

Copy link
Member

@chris-crone chris-crone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We should update the buildx README too

@hakman
Copy link

hakman commented Aug 4, 2020

Somewhat related, any thoughts about docker manifest? Will it be removed or maybe become non-experimental too?

@thaJeztah
Copy link
Member Author

Still being discussed; we may remove the "experimental" requirement itself, but there's still (UX) issues with those subcommands that should be looked into, so they may still be marked "experimental" (in the documentation), to indicate that backward-compatibility of the commands is not guaranteed.

@thaJeztah
Copy link
Member Author

We should update the buildx README too

@chris-crone yes, I had that one open in a tab; should be updated that starting with 20.x it's not needed to set the configuration (unless we decide to backport this change to 19.03, in which case the patch release version should be mentioned)

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@thaJeztah thaJeztah merged commit ddab5d3 into docker:master Aug 5, 2020
@thaJeztah thaJeztah deleted the buildx_remove_experimental_gate branch August 5, 2020 21:28
@thaJeztah thaJeztah changed the title plugins: don't require "experimental" for buildx [master] plugins: don't require "experimental" for buildx Aug 8, 2020
rgl added a commit to rgl/example-docker-buildx-go that referenced this pull request Jun 28, 2021
since docker 20.10 buildx is no longer experimental

see docker/docker-ce-packaging#490
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants