Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installing latest 5.0.3 on windows machines is still using pywin32==227 but not pywin32==301 #2902

Closed
keerthiadu opened this issue Oct 18, 2021 · 15 comments · Fixed by #3004
Closed

Comments

@keerthiadu
Copy link

Bump pywin32 from 227 to 301 was already merged in to bump pywin32 from 227 to 301. But, when installing latest 5.0.3 on windows machines is resulting in install of pywin32==227

Most likely extras_require needs updated

':sys_platform == "win32"': 'pywin32==227',

@tharun634
Copy link

Can confirm this issue, this is what happens while trying to install using poetry
image

Robpol86 added a commit to Robpol86/robpol86.com that referenced this issue Nov 1, 2021
Remove tests since they're all disabled and one (docker) has a security
issue: docker/docker-py#2902
Robpol86 added a commit to Robpol86/robpol86.com that referenced this issue Nov 1, 2021
Remove tests since they're all disabled and one (docker) has a security
issue: docker/docker-py#2902
@xoxys
Copy link

xoxys commented Nov 3, 2021

This issue exist on Python Poetry projects as well even if v5.0.3 is used already, https://github.com/thegeeklab/docker-tidy/security/dependabot/poetry.lock/pywin32/open

@jackwhelpton
Copy link

Also being bitten by this. FYI, there's a further update to pywin32, to 302. 302 is the first version to support Python 3.10, so is a key thing for us... is that covered by this ticket, or should I cut a new one for pywin32==302?

@tharun634
Copy link

Also being bitten by this. FYI, there's a further update to pywin32, to 302. 302 is the first version to support Python 3.10, so is a key thing for us... is that covered by this ticket, or should I cut a new one for pywin32==302?

This ticket doesn't do it, but there already is a PR which covers it, #2857

skshetry added a commit to skshetry/dvc that referenced this issue Nov 20, 2021
pygit2 wheels should be now available.
Had to skip pytest-docker for Windows + Python 3.10 due to
a dependency issue with it's dependency, see:
docker/docker-py#2902.
skshetry added a commit to iterative/dvc that referenced this issue Nov 20, 2021
pygit2 wheels should be now available.
Had to skip pytest-docker for Windows + Python 3.10 due to
a dependency issue with it's dependency, see:
docker/docker-py#2902.
efiop pushed a commit to iterative/dvc that referenced this issue Nov 20, 2021
pygit2 wheels should be now available.
Had to skip pytest-docker for Windows + Python 3.10 due to
a dependency issue with it's dependency, see:
docker/docker-py#2902.
@gitpushdashf
Copy link

Any update on this? There's known vulnerabilities with pywin 227: https://security.snyk.io/vuln/SNYK-PYTHON-PYWIN32-1316226

@Martin-Molinero
Copy link

Ping!
This issue means that you basically can't use python 3.10 and docker in windows. @StefanScherer @ulyssessouza @aiordache there are a few PRs already open to solve this, can they be reviewed/shipped anytime soon?

@jmackay-godaddy
Copy link

jmackay-godaddy commented May 20, 2022

Docker team, PLEASE can you accept any of the many already submitted fixes for this? People using docker through python and also on github cloud are getting security notifications due to your library. It is happening regardless of whether or not the team uses windows because githubs analysis cares only about transitive dependencies. This bug has been open for 8 months.

FWIW this fix properly preserves python 2 support which might be safer for more users for the time being: #2955

Screen Shot 2022-05-20 at 12 41 50 PM

@aabmets
Copy link

aabmets commented Jun 3, 2022

I got around this problem by removing all docker software and using an alternative, as all docker software seems to have become abandonware and incompatible with the current Python version.

@fproulx-boostsecurity
Copy link

I got around this problem by removing all docker software and using an alternative, as all docker software seems to have become abandonware and incompatible with the current Python version.

Which alternative did you end up using @aabmets ?

@aabmets
Copy link

aabmets commented Jun 22, 2022

I got around this problem by removing all docker software and using an alternative, as all docker software seems to have become abandonware and incompatible with the current Python version.

Which alternative did you end up using @aabmets ?

My use case was somewhat unique - using a container manager was an option, not a requirement. I needed to run QuestDB for a project and in addition to the docker container they also had a direct executable file available, so I just chose to run the exe directly from Python code in a subprocess.

@Dramelac
Copy link

Dramelac commented Jul 6, 2022

Is docker still a thing ??

It's been 8 months that this blocking problem prevents all Windows users to use the python docker lib in Python 3.10... More and more user must downgrade Python or drop Docker support...
And this is not even a technical problem, many PRs are already available for a very long time to correct this critical problem...

Knowing that one of the strategy of docker today is to put forward Docker Desktop (pro) with the Windows environment, it is all the more surprising / worrying that nothing is happening on this issue!

last hope? @StefanScherer could you address this issue to someone please ?

@SpangleLabs
Copy link

Looks like they're considering just abandoning the package #2989

@droserasprout
Copy link

I think it's a dangerous situation when the only fully-featured Docker management library (correct me if I'm wrong) is abandoned. Furthermore, contains significant vulnerabilities.

Are there any volunteers to maintain a fork? We could create an organization like docker-py-ng and export all issues and pull requests there using https://github.com/gavinr/github-csv-tools or similar tools. I have some experience maintaining Python projects, but I have been very constrained in my free time lately. 399 issues and 122 PRs are a great amount of work.

@bblommers
Copy link

Ideally the project is donated of course, but if there is no further communication around this, I wouldn't mind help maintaining a fork @droserasprout . Another of my OSS projects relies heavily on docker-py, so it would be nice to have some continuity.

Considering the project scope and personal time-constraints it could just be a maintenance fork, where we only consider security fixes and version compatibility PR's.

@droserasprout
Copy link

Sorry, I didn't notice the discussion of potential forking in another issue. Also, it appeared that docker-py is not the only Docker library around.

milas added a commit to milas/docker-py that referenced this issue Jul 25, 2022
Upgrade to latest pywin32, which has support for Python 3.10 and
resolves a CVE (related to ACL APIs, outside the scope of what
`docker-py` relies on, which is npipe support, but still gets
flagged by scanners).

The version constraint has also been relaxed in `setup.py` to allow
newer versions of pywin32. This is similar to how we handle the
other packages there, and should be safe from a compatibility
perspective.

Fixes docker#2902.
Closes docker#2972 and closes docker#2980.
milas added a commit to milas/docker-py that referenced this issue Jul 25, 2022
Upgrade to latest pywin32, which has support for Python 3.10 and
resolves a CVE (related to ACL APIs, outside the scope of what
`docker-py` relies on, which is npipe support, but still gets
flagged by scanners).

The version constraint has also been relaxed in `setup.py` to allow
newer versions of pywin32. This is similar to how we handle the
other packages there, and should be safe from a compatibility
perspective.

Fixes docker#2902.
Closes docker#2972 and closes docker#2980.

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
milas added a commit that referenced this issue Jul 26, 2022
Upgrade to latest pywin32, which has support for Python 3.10 and
resolves a CVE (related to ACL APIs, outside the scope of what
`docker-py` relies on, which is npipe support, but still gets
flagged by scanners).

The version constraint has also been relaxed in `setup.py` to allow
newer versions of pywin32. This is similar to how we handle the
other packages there, and should be safe from a compatibility
perspective.

Fixes #2902.
Closes #2972 and closes #2980.

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet