New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pywin32 upgrade #2972
Pywin32 upgrade #2972
Conversation
@StefanScherer could you help with this? |
Signed-off-by: Igor Sadchenko <igor.sadchenko@gmail.com>
Signed-off-by: Igor Sadchenko <igor.sadchenko@gmail.com>
33cf395
to
be06f16
Compare
@justincormack @thaJeztah maybe you know the answer who can help with that? |
Signed-off-by: Igor Sadchenko <igor.sadchenko@gmail.com>
Upgrade to latest pywin32, which has support for Python 3.10 and resolves a CVE (related to ACL APIs, outside the scope of what `docker-py` relies on, which is npipe support, but still gets flagged by scanners). The version constraint has also been relaxed in `setup.py` to allow newer versions of pywin32. This is similar to how we handle the other packages there, and should be safe from a compatibility perspective. Fixes docker#2902. Closes docker#2972 and closes docker#2980.
Upgrade to latest pywin32, which has support for Python 3.10 and resolves a CVE (related to ACL APIs, outside the scope of what `docker-py` relies on, which is npipe support, but still gets flagged by scanners). The version constraint has also been relaxed in `setup.py` to allow newer versions of pywin32. This is similar to how we handle the other packages there, and should be safe from a compatibility perspective. Fixes docker#2902. Closes docker#2972 and closes docker#2980. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
Upgrade to latest pywin32, which has support for Python 3.10 and resolves a CVE (related to ACL APIs, outside the scope of what `docker-py` relies on, which is npipe support, but still gets flagged by scanners). The version constraint has also been relaxed in `setup.py` to allow newer versions of pywin32. This is similar to how we handle the other packages there, and should be safe from a compatibility perspective. Fixes #2902. Closes #2972 and closes #2980. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
Hi! Thanks so much for your PR and apologies for the delay in review. A fix for this has been merged and we're planning to issue a new release containing it soon. For context, changes similar to yours were done in #3004 to address some CI changes in the repo, which blocked merging of your PR as-is, and given the delay on this, we wanted to be respectful of our contributor's time and not require you to rebase + re-review. |
Fix issue #2902
@aiordache @ulyssessouza, please, accept this PR to fix this annoying bug