Add NetworkAttachmentConfig for service create/update #2333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current documentation makes it appear like the only way to attach networks to a service is to provide them as a list of strings of ids/names.
Attaching networks also support setting aliases and driver options. I've added the new type
docker.types.NetworkAttachmentConfig
which is used to document these features.I also found that a documentation link to
ConfigReference
did not work. It should be referenced asdocker.types.ConfigReference
, this is now fixed.docker.types.ConfigReference
was also referenced by its absolute path. I changed this to make the documentation a bit easier to read.