Switch from pypiwin32 to pywin32 #2469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the supported versions of python are 2.7 and 3.5+, we can switch to pywin32 (which as of 223 supports 2.7, 3.5, 3.6 and 3.7). Arguably the lower bound is not required; it's merely included such that for python 3+ the requirement remains the same as pypiwin32==223 was a proxy for pywin32>=223. Signed-off-by: Bill Collins <bill@bill.works>
mrginglymus
force-pushed
the
pywin32
branch
2 times, most recently
from
89607a2
to
017472b
Compare
Signed-off-by: Bill Collins <bill@bill.works>
|
Can this be merged to master? the |
|
Can this be merged? The issue might be preventing me from installing the moto package on my system getmoto/moto#2686 |
|
Fixed in #2593 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the supported versions of python are 2.7 and 3.5+, we can
switch to pywin32 (which as of 223 supports 2.7, 3.5, 3.6 and 3.7).
Arguably the lower bound is not required; it's merely included such that
for python 3+ the requirement remains the same as pypiwin32==223 was a
proxy for pywin32>=223.
Signed-off-by: Bill Collins bill@bill.works