Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Windows dependency #2593

Merged
merged 1 commit into from Jul 7, 2020
Merged

Upgrade Windows dependency #2593

merged 1 commit into from Jul 7, 2020

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Jun 10, 2020

Another attempt at #2047

pypiwin32 is completely deprecated as pywin32 moved to GitHub and now ships binary wheels itself. Also, it seems the bug introduced in 222 has been fixed.

https://github.com/mhammond/pywin32
https://pypi.org/project/pywin32/#files
mhammond/pywin32#1153

Signed-off-by: Ofek Lev <ofekmeister@gmail.com>
@ofek
Copy link
Contributor Author

ofek commented Jun 10, 2020

@ulyssessouza @thaJeztah

@ofek
Copy link
Contributor Author

ofek commented Jun 16, 2020

Any update?

Copy link
Collaborator

@ulyssessouza ulyssessouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulyssessouza ulyssessouza merged commit c65d437 into docker:master Jul 7, 2020
@ofek ofek deleted the pywin32 branch July 7, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants