Put back identityfile parameter from .ssh/config #2846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shehzaman
commented
May 26, 2021
| @@ -205,17 +205,18 @@ def _create_paramiko_client(self, base_url): | |||
| with open(ssh_config_file) as f: | |||
| conf.parse(f) | |||
| host_config = conf.lookup(base_url.hostname) | |||
| self.ssh_conf = host_config | |||
There was a problem hiding this comment.
Removed this variable, it was contributing nothing to the code.
shehzaman
commented
May 26, 2021
Comment on lines
+218
to
+219
| if 'identityfile' in host_config: | ||
| self.ssh_params['key_filename'] = host_config['identityfile'] |
There was a problem hiding this comment.
Important bits to review
shehzaman
changed the title
|
Could you please merge this PR. Thanks a lot! |
aiordache
approved these changes
Aug 31, 2021
Signed-off-by: Shehzaman <shehzi.1@gmail.com>
ulyssessouza
force-pushed
the
feature/missing-identity-file
branch
from
11544b4
to
8da03e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shehzaman
fixes #2845