Use url-safe base64 when encoding auth header #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if six.PY2 and sys.version_info[1] <= 6: | ||
| return self.assertTrue(object not in collection) | ||
| return super(BaseTestCase, self).assertNotIn(object, collection) | ||
|
|
There was a problem hiding this comment.
Now that the tests use py.test, you could just use assert x not in y and get a really nice error message when it fails! (instead of having this wrapper)
|
some CI failures, otherwise looks good |
+ regression test Signed-off-by: Joffrey F <joffrey@docker.com>
shin-
added a commit
that referenced
this pull request
Oct 9, 2015
Use url-safe base64 when encoding auth header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #803