Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: verify and/or update #1860

Closed
mhennings opened this issue Sep 11, 2013 · 12 comments
Closed

feature request: verify and/or update #1860

mhennings opened this issue Sep 11, 2013 · 12 comments
Labels
area/distribution exp/expert kind/feature Functionality or other elements that the project doesn't currently have. Features are new and shiny

Comments

@mhennings
Copy link
Contributor

when you work locally with images it can happen that your local state differs to the remote state.

i see the following causes:

  • local build, never pushed, older than remote
  • local checksum not valid (local change/ fscorruption, whatever)
  • newer remote

for this i would like to have some kind of "verify" or "update" command to get in sync.

i am aware that pull will fetch the newest remote, but it will overwrite local images even if they are newer.

also pull will not verify checksums.

beside this, it would be nice if there was an option to run that will verify before running.

what do you think?

@crosbymichael
Copy link
Contributor

I like the idea. What do you think @vieux @shykes @creack

@creack
Copy link
Contributor

creack commented Jan 9, 2014

I think it would be difficult. The registry is pretty dumb and does not process the images sent. In order to do this we would need a much smarter registry.
ping @samalba @shin-

@vbatts
Copy link
Contributor

vbatts commented Jun 10, 2014

I like this as well, but this also would require either versioning of image names, or some notion of incrementing the image name (perhaps in addition to the date of the image build).

Verifying is separate, but related. I am interested in this being done too.

@thaJeztah
Copy link
Member

Would this be possible once layer checksums are implemented? At least that would allow me to check which local images are out of date. Maybe add some system to check which containers are built from an outdated base-image.

@mhennings
Copy link
Contributor Author

Each layer already has a checksum (if noone removed tarsum recently)

So its not hard to implement. More or less reading the layer into a tar stream and building a tarsum on it.

Problem is though that on some backends the tarsum will probably always complain, because the backend does not handle all attributes / corner cases properly. (which means: aufs would often say its not the same checksum).

@thaJeztah
Copy link
Member

Clear, thanks!

Was just today thinking if it would be possible to check which containers would need a rebuild, in case a base-image was updated. I think it is related, not 100% the same as this issue.

@vbatts
Copy link
Contributor

vbatts commented Jul 27, 2014

@mhennings The backend graphdriver doesn't matter for the TarSum, only for the container runtime. TarSum are so far consistent regardless of the graphdriver. And TarSum has not been removed, so that is good :-)

As a side-note, in my efforts to clean up the registry code of the daemon, I've got a branch working on comparing freshness of an image. Should have a PR shortly.

@thaJeztah
Copy link
Member

@vbatts thanks in advance! I saw some progress on fingerprinting/signing images. Will keep track :)

@jessfraz jessfraz added exp/expert kind/feature Functionality or other elements that the project doesn't currently have. Features are new and shiny and removed /project/helpwanted exp/expert labels Feb 25, 2015
@LK4D4
Copy link
Contributor

LK4D4 commented Sep 15, 2016

@thaJeztah @tonistiigi Do you think it's possible to do now? Still worth it?

@thaJeztah
Copy link
Member

Isn't this what Docker Content Trust basically does? https://docs.docker.com/engine/security/trust/content_trust/

/cc @endophage

@tonistiigi
Copy link
Member

At least some of this was addressed with content addressability in v1.10

@LK4D4
Copy link
Contributor

LK4D4 commented Sep 15, 2016

@thaJeztah @tonistiigi let's then close it and if someone interest will open new issue with current concerns.

@LK4D4 LK4D4 closed this as completed Sep 15, 2016
trebonian pushed a commit to trebonian/docker that referenced this issue Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/distribution exp/expert kind/feature Functionality or other elements that the project doesn't currently have. Features are new and shiny
Projects
None yet
Development

No branches or pull requests