Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default application bundle name for docker deploy command #24249

Closed
arun-gupta opened this issue Jul 2, 2016 · 4 comments
Closed

Change default application bundle name for docker deploy command #24249

arun-gupta opened this issue Jul 2, 2016 · 4 comments
Labels
area/cli area/stack area/swarm kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. kind/experimental

Comments

@arun-gupta
Copy link
Contributor

Docker version 1.12.0-rc2-beta17

Use the following docker-compose.yml:

version: "2"
services:
  db:
    container_name: "db"
    image: arungupta/oreilly-couchbase:latest
    ports:
      - 8091:8091
      - 8092:8092 
      - 8093:8093 
      - 11210:11210
  web:
    image: arungupta/oreilly-wildfly:latest
    depends_on:
      - db
    environment:
      - COUCHBASE_URI=db
    ports:
      - 8080:8080

Generate a Distributed Application Bundle as docker-compose bundle:

hello-javaee > docker-compose bundle
WARNING: Unsupported key 'depends_on' in services.web - ignoring
WARNING: Unsupported key 'container_name' in services.db - ignoring
Wrote bundle to hellojavaee.dsb

Give the command docker deploy in the same directory:

docker deploy
"docker deploy" requires exactly 1 argument(s).
See 'docker deploy --help'.

Usage:  docker deploy [OPTIONS] STACK

Create and update a stack

It would simplify the command usage if the default project name is automatically chosen. The current default is STACK.dsb. It would be great if in this case it is defaulted to hellojavaee.dsb.

@thaJeztah thaJeztah added this to the 1.12.0 milestone Jul 2, 2016
@thaJeztah thaJeztah added the kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. label Jul 2, 2016
@thaJeztah
Copy link
Member

ping @mgoelzer @aanand

@dnephin dnephin removed this from the 1.12.0 milestone Jul 5, 2016
@dnephin
Copy link
Member

dnephin commented Jul 5, 2016

The default name is the name of the stack you want to deploy to.

We could default to the normalized basename like Compose but we've seen that cause a lot of confusion. It might be better to require a name from docker-compose bundle instead of assuming a default here.

@aanand
Copy link
Contributor

aanand commented Jul 5, 2016

Yeah, I don't know if we want to carry the basename convention forward into the Docker CLI. It's very hard to change once it's in.

@thaJeztah
Copy link
Member

Let me close this ticket for now, as it looks like it went stale.

@thaJeztah thaJeztah closed this as not planned Won't fix, can't repro, duplicate, stale Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli area/stack area/swarm kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. kind/experimental
Projects
None yet
Development

No branches or pull requests

4 participants