Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.0 backport] hack: remove -installsuffix build flag #44884

Merged
merged 4 commits into from Jan 31, 2023
Merged

[23.0 backport] hack: remove -installsuffix build flag #44884

merged 4 commits into from Jan 31, 2023

Conversation

thaJeztah
Copy link
Member

@crazy-max @thaJeztah
hack: remove -installsuffix build flag
df2fe70 
Has been introduced in 232d59b to work around a bug with
"go build" but not required anymore since go 1.5: golang/go@4dab6d0

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
(cherry picked from commit 0c008cc)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@crazy-max @thaJeztah
hack: remove ORIG_BUILDFLAGS var
9674623 
This var was used for the cross target but it has been removed
in 8086f40 so not necessary anymore

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
(cherry picked from commit b80f161)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@crazy-max @thaJeztah
hack: remove unnecessary vars in make.sh script
b7e0725 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
(cherry picked from commit 877baae)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@crazy-max @thaJeztah
hack: display build cmd when DOCKER_DEBUG set
699e853 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
(cherry picked from commit 170a1c4)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 23.0.0 milestone Jan 30, 2023
@thaJeztah
Copy link
Member Author

Let me bring this one in 👍

@thaJeztah thaJeztah merged commit de3f216 into moby:23.0 Jan 31, 2023
@thaJeztah thaJeztah deleted the 23.0_backport_rm_install_suffix branch January 31, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazy-max crazy-max crazy-max approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@tianon tianon Awaiting requested review from tianon tianon is a code owner

Assignees
No one assigned
Labels
area/packaging status/2-code-review
Projects
None yet
Milestone
23.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thaJeztah @crazy-max @AkihiroSuda