pkg/archive: Canonicalize stored paths

[ahmetb]

Currently pkg/archive stores nested windows files with
backslashes (e.g. dir\, dir\file.txt) and this causes
tar not being correctly extracted on Linux daemon.

This change assures we canonicalize all paths to unix
paths and add them to tar with that name independent of platform.
For example windows paths like dir\foo.txt gets stored as dir/foo.txt
and dir\ entry gets stored as dir/ in the tar.

With this change we sustain unix-style paths in Dockerfiles
and .dockerignore files. The windows daemon probably needs to
modify the logic to untar unix paths correctly on windows filesystems.

Fixes the following test cases for Windows CI:

• TestBuildAddFileWithWhitespace
• TestBuildCopyFileWithWhitespace
• TestBuildAddDirContentToRoot
• TestBuildAddDirContentToExistingDir
• TestBuildCopyDirContentToRoot
• TestBuildCopyDirContentToExistDir
• TestBuildDockerignore
• TestBuildEnvUsage
• TestBuildEnvUsage2
• TestBuildCopyWildcard

Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com
cc: @unclejack @tiborvass @icecrime @jfrazelle @swernli @jhowardmsft @jeffmendoza

[ahmetb]

https://jenkins.dockerproject.com/job/Windows-PRs/57/console

=== RUN TestBuildAddFileWithWhitespace
[PASSED]: build - add file with whitespace
--- PASS: TestBuildAddFileWithWhitespace (4.17s)
=== RUN TestBuildCopyFileWithWhitespace
[PASSED]: build - copy file with whitespace
--- PASS: TestBuildCopyFileWithWhitespace (4.19s)
[...]
=== RUN TestBuildAddDirContentToRoot
[PASSED]: build - add directory contents to root
--- PASS: TestBuildAddDirContentToRoot (1.75s)
=== RUN TestBuildAddDirContentToExistingDir
[PASSED]: build - add directory contents to existing dir
--- PASS: TestBuildAddDirContentToExistingDir (2.87s)
[...]
=== RUN TestBuildCopyDirContentToRoot
[PASSED]: build - copy directory contents to root
--- PASS: TestBuildCopyDirContentToRoot (1.61s)
=== RUN TestBuildCopyDirContentToExistDir
[PASSED]: build - copy directory contents to existing dir
--- PASS: TestBuildCopyDirContentToExistDir (2.98s)
[...]
=== RUN TestBuildDockerignore
[PASSED]: build - test .dockerignore
--- PASS: TestBuildDockerignore (3.22s)
[...]
=== RUN TestBuildEnvUsage
[PASSED]: build - environment variables usage
--- PASS: TestBuildEnvUsage (3.04s)
=== RUN TestBuildEnvUsage2
[PASSED]: build - environment variables usage2
--- PASS: TestBuildEnvUsage2 (5.78s)

👍 happy CI is happy.

[jessfraz]

ping @unclejack for archive stuffs :)

[unclejack]

LGTM

[LK4D4]

it is really impossible to have / in path even escaped?

[ahmetb]

@LK4D4 you can't. http://stackoverflow.com/a/10708449/54929
but as a precautionary measure, I check for "/" and if it's there we just fail rather than blindly replacing it.

[LK4D4]

windows is really wonderland

[LK4D4]

LGTM

[ahmetb]

Got 2 LGTMs, what now?

[crosbymichael]

Is this supposed to fail on windows right now?

[ahmetb]

@crosbymichael I'm not sure what you mean but if we build build context using windows CLI right now, nested paths are stored with backslashes, and therefore on linux daemon side, all those nested files are extracted as filenames with backslashes rather than going inside these directories. this fixes that.

edit: per our irc convo, yes, windows CI is expected to fail for everything, we're counting down from 100 failures to a green CI at this point.

[crosbymichael]

LGTM