integ-cli: skip tests launching registry-v2 #11005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some pull/push tests are launching `registry-v2` binary which is compiled and installed if the tests are running in-container through `make test-integration-cli`. However, registry is not supported to run on non-linux platforms and we can't really spin up any registry-v2 containers in the remote DOCKER_TEST_HOST at this point. Just skipping those with the new TestRequirement called `RegistryHosting`. Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
|
|
|
+1 -- let's revisit when we have a registry-v2 image IMO
|
|
@tianon does it make sense to skip at this point or not? |
|
Yeah, I agree -- let's skip for now and revisit when we have a good official registry-v2 image. 👍 |
|
LGTM |
1 similar comment
|
LGTM |
jessfraz
pushed a commit
that referenced
this pull request
Mar 2, 2015
integ-cli: skip tests launching registry-v2
tianon
added a commit
to tianon/docker
that referenced
this pull request
Mar 2, 2015
This is the absolute bare minimum necessary to compile and test Docker -- this is going to be especially useful for testing and verifying assumptions. With this, we can setup a Jenkins job that tests to ensure that all the work we do to make sure our build scripts and tests don't contain assumptions is not effort spent in vain. This is important because this is the kind of bare-bones stock environment our packagers build in. Additionally, this verifies that our scripts will work reasonably on other platforms (such as Darwin and Windows) as well. Assumptions existing tests make that currently fail: - `registry-v2` exists as a binary in `$PATH` (FIXED IN moby#11005 🎉) - `unprivilegeduser` exists as a user in `/etc/passwd` Signed-off-by: Andrew "Tianon" Page <admwiggin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some pull/push tests are launching a local
registry-v2binary which is compiled and installed if the tests
are running in-container through
make test-integration-cli.However, registry is not supported to run on non-linux
platforms and we can't really spin up any registry-v2
containers in the remote DOCKER_TEST_HOST at this point.
Just skipping those with the new TestRequirement called
RegistryHosting. If the registry-v2 image becomes availablewe can take a path like #10893 and spin up registry containers
at the remote daemon hosts and re-enable tests.
Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com
cc: @tianon @unclejack @jfrazelle @icecrime @LK4D4