Add more amazing women to the names generator. #15218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Satyendra Nath Bose - He provided the foundation for Bose–Einstein statistics and the theory of the Bose–Einstein condensate. - https://en.wikipedia.org/wiki/Satyendra_Nath_Bose | ||
| "bose", | ||
|
|
||
| // Evelyn Boyd Granville - Swas one of the first African-American women to receive a Ph.D. in mathematics; she earned it in 1949 from Yale University. https://en.wikipedia.org/wiki/Evelyn_Boyd_Granville |
calavera
force-pushed
the
gender_unbiased_names
branch
from
031ac3b
to
3af8e06
Compare
|
👍 |
| @@ -149,6 +165,12 @@ var ( | |||
| // Leonardo Da Vinci invented too many things to list here. https://en.wikipedia.org/wiki/Leonardo_da_Vinci. | |||
| "davinci", | |||
|
|
|||
| // Donna Dubinsky, CEO and co-founder of Palm, Inc. https://en.wikipedia.org/wiki/Donna_Dubinsky | |||
| "dubinsky", | |||
There was a problem hiding this comment.
Will probably not make me popular; is co-founding a company notable enough to make it in this list?
(Read the linked Wikipedia page; there are some notable things in there, so possibly with a better description)
There was a problem hiding this comment.
Read through the list again; possibly I'm too strict, just want to guard against companies wanting to add founders to the list, just because they founded a company.
Signed-off-by: David Calavera <david.calavera@gmail.com>
calavera
force-pushed
the
gender_unbiased_names
branch
from
3af8e06
to
85a0f56
Compare
|
LGTM |
1 similar comment
|
LGTM |
jessfraz
pushed a commit
that referenced
this pull request
Aug 21, 2015
Add more amazing women to the names generator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you know that we have 62 men in the names generator but only 33 women?
This change makes the number of men and women equal.
Signed-off-by: David Calavera david.calavera@gmail.com