code.google.com is shutting down so update the dep #16054

jessfraz · 2015-09-03T17:12:23Z

cpuguy83 · 2015-09-03T17:17:27Z

Or review #16032 :)

tiborvass · 2015-09-04T00:00:03Z

hack/vendor.sh

@@ -18,7 +18,7 @@ clone git github.com/microsoft/hcsshim 7f646aa6b26bcf90caee91e93cde4a80d0d8a83e
 clone git github.com/mistifyio/go-zfs v2.1.1
 clone git github.com/tchap/go-patricia v2.1.0
 clone git golang.org/x/net 3cffabab72adf04f8e3b01c5baf775361837b5fe https://github.com/golang/net.git
-clone hg code.google.com/p/gosqlite 74691fb6f837
+clone git github.com/mxk/go-sqlite 167da9432e1f4602e95ea67b67051cfa34412e3f


is there a commit that's closer to the original? there's a lot of code change.

As far as time is concerned, mxk/go-sqlite@1ad6fca is pretty close to what we were using before. (May 30, 2013 vs May 25, 2013; https://code.google.com/p/gosqlite/source/detail?r=74691fb6f83716190870cde1b658538dd4b18eb0)

Not sure if that actually means anything, and haven't had a chance to check the code diff yet.

ya i dont think it does :/ i tried to see the commits to the hq repo, but they dont align, however they were pointing people to use this repo, so its semi weird...

Do you happen to have a link to where they suggest using this particular repo? I can't find any suggestion like that myself. 😢

Alternatively, we could switch over to go-sqlite3 completely (#15387 (comment)).

https://code.google.com/p/go-sqlite/

On Thu, Sep 3, 2015 at 5:18 PM, Tianon Gravi notifications@github.com
wrote:

In hack/vendor.sh
#16054 (comment):

@@ -18,7 +18,7 @@ clone git github.com/microsoft/hcsshim 7f646aa6b26bcf90caee91e93cde4a80d0d8a83e
clone git github.com/mistifyio/go-zfs v2.1.1
clone git github.com/tchap/go-patricia v2.1.0
clone git golang.org/x/net 3cffabab72adf04f8e3b01c5baf775361837b5fe https://github.com/golang/net.git
-clone hg code.google.com/p/gosqlite 74691fb6f837
+clone git github.com/mxk/go-sqlite 167da9432e1f4602e95ea67b67051cfa34412e3f

Do you happen to have a link to where they suggest using this particular
repo? I can't find any suggestion like that myself. [image: 😢]

Alternatively, we could switch over to go-sqlite3 completely (#15387
(comment)
#15387 (comment)).

—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/16054/files#r38711350.

I'm tryinng that sha tho

On Thu, Sep 3, 2015 at 5:19 PM, Jessie Frazelle jess@docker.com wrote:

https://code.google.com/p/go-sqlite/

On Thu, Sep 3, 2015 at 5:18 PM, Tianon Gravi notifications@github.com
wrote:

In hack/vendor.sh
#16054 (comment):

@@ -18,7 +18,7 @@ clone git github.com/microsoft/hcsshim 7f646aa6b26bcf90caee91e93cde4a80d0d8a83e
clone git github.com/mistifyio/go-zfs v2.1.1
clone git github.com/tchap/go-patricia v2.1.0
clone git golang.org/x/net 3cffabab72adf04f8e3b01c5baf775361837b5fe https://github.com/golang/net.git
-clone hg code.google.com/p/gosqlite 74691fb6f837
+clone git github.com/mxk/go-sqlite 167da9432e1f4602e95ea67b67051cfa34412e3f

Do you happen to have a link to where they suggest using this particular
repo? I can't find any suggestion like that myself. [image: 😢]

Alternatively, we could switch over to go-sqlite3 completely (#15387
(comment)
#15387 (comment)).

—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/16054/files#r38711350.

Wow, I obviously can't read. 😳

It is really crazy that it doesn't have the proper hg history imported though. I can't imagine why they wouldn't.

right its so weird!

On Thu, Sep 3, 2015 at 5:24 PM, Tianon Gravi notifications@github.com
wrote:

In hack/vendor.sh
#16054 (comment):

@@ -18,7 +18,7 @@ clone git github.com/microsoft/hcsshim 7f646aa6b26bcf90caee91e93cde4a80d0d8a83e
clone git github.com/mistifyio/go-zfs v2.1.1
clone git github.com/tchap/go-patricia v2.1.0
clone git golang.org/x/net 3cffabab72adf04f8e3b01c5baf775361837b5fe https://github.com/golang/net.git
-clone hg code.google.com/p/gosqlite 74691fb6f837
+clone git github.com/mxk/go-sqlite 167da9432e1f4602e95ea67b67051cfa34412e3f

It is really crazy that it doesn't have the proper hg history imported
though. I can't imagine why they wouldn't.

—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/16054/files#r38711689.

jessfraz · 2015-09-04T00:29:55Z

the diff is so completely different idk

jessfraz · 2015-09-04T00:30:11Z

maybe we should just use something else :/

tianon · 2015-09-04T00:31:19Z

Yeah, that's why I suggested we should consider/test mattn's go-sqlite3 that we're already importing. 👍

jessfraz · 2015-09-04T00:32:34Z

ooo yeah i will pop it out i didnt know if there is a reson we werent using it already

tianon · 2015-09-04T00:33:31Z

There was, but it's been shown to work successfully for packaging needs, so I'm +1. 👍

jessfraz · 2015-09-04T00:36:06Z

cool! updated!

tianon · 2015-09-04T00:39:08Z

pkg/graphdb/conn_sqlite3_unix.go

@@ -3,5 +3,5 @@
 package graphdb

 import (
-	_ "code.google.com/p/gosqlite/sqlite3" // registers sqlite
+	_ "github.com/github.com/mattn/go-sqlite3" // registers sqlite


github.com/github.com

ah i was too slow to fix and you saw it :ashamed:

On Thu, Sep 3, 2015 at 5:40 PM, Tianon Gravi notifications@github.com
wrote:

In pkg/graphdb/conn_sqlite3_unix.go
#16054 (comment):

@@ -3,5 +3,5 @@
package graphdb

import (

_ "code.google.com/p/gosqlite/sqlite3" // registers sqlite

_ "github.com/github.com/mattn/go-sqlite3" // registers sqlite

github.com/github.com

—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/16054/files#r38712452.

Signed-off-by: Jessica Frazelle <acidburn@docker.com>

jessfraz · 2015-09-04T01:25:53Z

it works!

jessfraz · 2015-09-04T01:26:16Z

omg @LK4D4 will be excited we only have 1 sqlite package now 🎊

tianon · 2015-09-04T01:29:16Z

LGTM

diogomonica · 2015-09-04T02:19:45Z

LGTM

code.google.com is shutting down so update the dep

mountkin · 2015-09-06T04:06:36Z

There's a warning when running make binary.

---> Making bundle: binary (in bundles/1.9.0-dev/binary)
Building: bundles/1.9.0-dev/binary/docker-1.9.0-dev
# github.com/docker/docker/docker
/var/tmp/go-link-pJY0ZF/000006.o: In function `unixDlOpen':
/go/src/github.com/docker/docker/vendor/src/github.com/mattn/go-sqlite3/code/sqlite3-binding.c:29925: warning: Using 'dlopen' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking

jessfraz · 2015-09-06T04:17:33Z

It's fixed in another pr

On Sat, Sep 5, 2015 at 9:07 PM -0700, "Shijiang Wei" notifications@github.com wrote:

There's a warning when running make binary.

---> Making bundle: binary (in bundles/1.9.0-dev/binary)
Building: bundles/1.9.0-dev/binary/docker-1.9.0-dev

github.com/docker/docker/docker

/var/tmp/go-link-pJY0ZF/000006.o: In function `unixDlOpen':
/go/src/github.com/docker/docker/vendor/src/github.com/mattn/go-sqlite3/code/sqlite3-binding.c:29925: warning: Using 'dlopen' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking

—
Reply to this email directly or view it on GitHub.

jessfraz · 2015-09-06T04:17:55Z

It is just a warning tho we do not use dlopen

On Sat, Sep 5, 2015 at 9:07 PM -0700, "Shijiang Wei" notifications@github.com wrote:

There's a warning when running make binary.

---> Making bundle: binary (in bundles/1.9.0-dev/binary)
Building: bundles/1.9.0-dev/binary/docker-1.9.0-dev

github.com/docker/docker/docker

/var/tmp/go-link-pJY0ZF/000006.o: In function `unixDlOpen':
/go/src/github.com/docker/docker/vendor/src/github.com/mattn/go-sqlite3/code/sqlite3-binding.c:29925: warning: Using 'dlopen' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking

—
Reply to this email directly or view it on GitHub.

mountkin · 2015-09-06T04:34:34Z

I see. It's #16094
Thanks.

GordonTheTurtle added the status/0-triage label Sep 3, 2015

jessfraz added status/2-code-review and removed status/0-triage labels Sep 3, 2015

tiborvass reviewed Sep 4, 2015
View reviewed changes

jessfraz force-pushed the update-sqlite3-dep branch 2 times, most recently from 510e1a6 to 6705943 Compare September 4, 2015 00:29

jessfraz force-pushed the update-sqlite3-dep branch from 6705943 to 5efd2ea Compare September 4, 2015 00:36

tianon reviewed Sep 4, 2015
View reviewed changes

code.google.com is shutting down so update the dep

4a864a7

Signed-off-by: Jessica Frazelle <acidburn@docker.com>

jessfraz force-pushed the update-sqlite3-dep branch from 5efd2ea to 4a864a7 Compare September 4, 2015 00:39

jessfraz mentioned this pull request Sep 4, 2015

replace godeps w bash for better control notaryproject/notary#192

Closed

jessfraz pushed a commit that referenced this pull request Sep 4, 2015

Merge pull request #16054 from jfrazelle/update-sqlite3-dep

38ecc7f

code.google.com is shutting down so update the dep

jessfraz merged commit 38ecc7f into moby:master Sep 4, 2015

jessfraz deleted the update-sqlite3-dep branch September 4, 2015 02:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

code.google.com is shutting down so update the dep #16054

code.google.com is shutting down so update the dep #16054

jessfraz commented Sep 3, 2015

cpuguy83 commented Sep 3, 2015

tiborvass Sep 4, 2015

tianon Sep 4, 2015

jessfraz Sep 4, 2015

tianon Sep 4, 2015

jessfraz Sep 4, 2015

jessfraz Sep 4, 2015

tianon Sep 4, 2015

tianon Sep 4, 2015

jessfraz Sep 4, 2015

jessfraz commented Sep 4, 2015

jessfraz commented Sep 4, 2015

tianon commented Sep 4, 2015 via email

jessfraz commented Sep 4, 2015

tianon commented Sep 4, 2015 via email

jessfraz commented Sep 4, 2015

tianon Sep 4, 2015

jessfraz Sep 4, 2015

jessfraz commented Sep 4, 2015

jessfraz commented Sep 4, 2015

tianon commented Sep 4, 2015

diogomonica commented Sep 4, 2015

mountkin commented Sep 6, 2015

jessfraz commented Sep 6, 2015

jessfraz commented Sep 6, 2015

mountkin commented Sep 6, 2015

code.google.com is shutting down so update the dep #16054

code.google.com is shutting down so update the dep #16054

Conversation

jessfraz commented Sep 3, 2015

cpuguy83 commented Sep 3, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jessfraz commented Sep 4, 2015

jessfraz commented Sep 4, 2015

tianon commented Sep 4, 2015 via email

jessfraz commented Sep 4, 2015

tianon commented Sep 4, 2015 via email

jessfraz commented Sep 4, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jessfraz commented Sep 4, 2015

jessfraz commented Sep 4, 2015

tianon commented Sep 4, 2015

diogomonica commented Sep 4, 2015

mountkin commented Sep 6, 2015

jessfraz commented Sep 6, 2015

github.com/docker/docker/docker

jessfraz commented Sep 6, 2015

github.com/docker/docker/docker

mountkin commented Sep 6, 2015