Remove deprecated Docker Content Trust ENV passphrase variables #22574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 1.9, Docker Content Trust Offline key has been renamed to Root key and the Tagging key has been renamed to Repository key. The corresponding environment variables `DOCKER_CONTENT_TRUST_OFFLINE_PASSPHRASE` `DOCKER_CONTENT_TRUST_TAGGING_PASSPHRASE` have also been deprecated and renamed to `DOCKER_CONTENT_TRUST_ROOT_PASSPHRASE` `DOCKER_CONTENT_TRUST_REPOSITORY_PASSPHRASE` This fix removed the deprecated ENV passphrase variables for 1.12 and updated the docs. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
yongtang
force-pushed
the
05072016-remove-deprecated-trust-env
branch
from
cb64ca7
to
1f0d5ab
Compare
thaJeztah
added
status/2-code-review
impact/changelog
impact/deprecation
and removed
status/0-triage
labels
|
LGTM ping @endophage @cyli @riyazdf ptal |
|
|
||
| - DOCKER_CONTENT_TRUST_OFFLINE_PASSPHRASE will now be named DOCKER_CONTENT_TRUST_ROOT_PASSPHRASE | ||
| - DOCKER_CONTENT_TRUST_TAGGING_PASSPHRASE will now be named DOCKER_CONTENT_TRUST_REPOSITORY_PASSPHRASE | ||
| - DOCKER_CONTENT_TRUST_OFFLINE_PASSPHRASE is named DOCKER_CONTENT_TRUST_ROOT_PASSPHRASE |
There was a problem hiding this comment.
Nonblocking minor nitpick: can we change "is named" to "is now named" or "has been renamed"?
|
LGTM |
|
Yep, LGTM. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 1.9, Docker Content Trust Offline key has been renamed to Root key and the Tagging key has been renamed to Repository key.
The corresponding environment variables
DOCKER_CONTENT_TRUST_OFFLINE_PASSPHRASEDOCKER_CONTENT_TRUST_TAGGING_PASSPHRASEhave also been deprecated and renamed to
DOCKER_CONTENT_TRUST_ROOT_PASSPHRASEDOCKER_CONTENT_TRUST_REPOSITORY_PASSPHRASEThis fix removed the deprecated ENV passphrase variables for 1.12 and updated the docs.
Signed-off-by: Yong Tang yong.tang.github@outlook.com