Allow docker inspect on all types
#23614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should add that this request comes straight from our BDFL. |
|
Questions :
|
|
Makes sense to me. |
|
@vdemeester True! Let me update this sometime today :-) Thanks |
|
@icecrime I think you can update |
|
@icecrime @vdemeester I won't do |
icecrime
force-pushed
the
inspect_services
branch
2 times, most recently
from
f4f6232
to
22bd0a0
Compare
|
Refactored the code and made it available to inspect all (but nodes!): still requires docker/engine-api#284 to work properly, as cascading between types is based off the ability to identify not found errors. |
icecrime
force-pushed
the
inspect_services
branch
2 times, most recently
from
308c5ae
to
bc9bc55
Compare
|
LGTM |
|
@icecrime needs a rebase |
icecrime
force-pushed
the
inspect_services
branch
from
bc9bc55
to
b3692fc
Compare
|
Rebased and hopefully good now. |
|
@icecrime tests are failing 😢 |
thaJeztah
added
the
status/failing-ci
icecrime
force-pushed
the
inspect_services
branch
from
b3692fc
to
b16f641
Compare
|
Thank you all <3 |
albers
added a commit
to albers/moby
that referenced
this pull request
Oct 4, 2016
services This enhances completion of networks, volumes, plugins, runtimes and local interfaces so that they are consistent with the principles introduced in the completions of nodes and services. This serves as a preparation for implementing bash completion for the enhanced functionality of docker inspeckt (moby#23614). Signed-off-by: Harald Albers <github@albersweb.de>
albers
added a commit
to albers/moby
that referenced
this pull request
Oct 25, 2016
…rameterized function In moby#23614 `docker inspect` was semantically enhanced to inspect "everything". Therefore moving its logic to `_docker_container_inspect` was not correct. This commit moves it back to its original top-level location (`_docker_inspect`) so that it can be called by `_docker_{container,image}_inspect` and others (will be added in follow-up PRs). Parameterization was added in order to get caller-specific behavior. Signed-off-by: Harald Albers <github@albersweb.de>
This was referenced Nov 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow top-level
docker inspectcommand to inspect any kind of resources. The rationale is thatinspectalready does images and containers for historical reasons, so it might as well support them all. More specialized inspects (e.g.,docker network inspect) should exist to support type specific options.Depends on docker/engine-api#283.