-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bash completion for new docker image
command family
#27719
Conversation
Signed-off-by: Harald Albers <github@albersweb.de>
Signed-off-by: Harald Albers <github@albersweb.de>
Signed-off-by: Harald Albers <github@albersweb.de>
Signed-off-by: Harald Albers <github@albersweb.de>
…rameterized function In moby#23614 `docker inspect` was semantically enhanced to inspect "everything". Therefore moving its logic to `_docker_container_inspect` was not correct. This commit moves it back to its original top-level location (`_docker_inspect`) so that it can be called by `_docker_{container,image}_inspect` and others (will be added in follow-up PRs). Parameterization was added in order to get caller-specific behavior. Signed-off-by: Harald Albers <github@albersweb.de>
Signed-off-by: Harald Albers <github@albersweb.de>
Signed-off-by: Harald Albers <github@albersweb.de>
Signed-off-by: Harald Albers <github@albersweb.de>
Signed-off-by: Harald Albers <github@albersweb.de>
Signed-off-by: Harald Albers <github@albersweb.de>
Signed-off-by: Harald Albers <github@albersweb.de>
Signed-off-by: Harald Albers <github@albersweb.de>
Testing this atm and I've stumbled into the following issue:
|
@mlaventure I did not change behavior here, and I also think it's correct, see:
|
@albers in my example It can be changed in a later PR, but I'd say the current behavior is incorrect as it causes the command to fail. |
@mlaventure Sorry, I didn't read your post properly, thought the problem was in I agree that the completion is wrong. As this is an existing bug, I suggest to fix it in a separate PR. |
LGTM in that case, all my other tests passed. Thanks @albers ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ 😍 LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐯
This is the second part of adding bash completion for #26025 (#27579 being the first one):
docker image *
.Like in #27579, I created one commit for the pricipal flow of logic and subsequent ones that move the completion logic to the new homes. This was done so that the changes can be easily reviewed (as all the changes were applied to the same file, the overall diff is not very helpful).
One of the commits is special. From the commit message:
For the new command
docker image prune
I just added a stub. I'll implement it in a follow-up PR.ping @thaJeztah @mlaventure @tianon