Implement service integration tests #24133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuguy83
force-pushed
the
hacky_swarm_integration_tests
branch
from
2ff9685
to
3fcee97
Compare
cpuguy83
changed the title
cpuguy83
changed the title
|
ping @vdemeester: there you go! 😄 |
cpuguy83
force-pushed
the
hacky_swarm_integration_tests
branch
from
3fcee97
to
9d00e11
Compare
| @@ -19,6 +20,7 @@ type SwarmDaemon struct { | |||
| swarm.Info | |||
| port int | |||
| listenAddr string | |||
| suite *DockerSwarmSuite | |||
There was a problem hiding this comment.
hHuzzah, I'm not! I was but I guess I ended up not needing it anymore.
cpuguy83
force-pushed
the
hacky_swarm_integration_tests
branch
from
9d00e11
to
8a9b659
Compare
| id := strings.TrimSpace(out) | ||
|
|
||
| var tasks []swarm.Task | ||
| wait(c, 30*time.Second, func() bool { |
There was a problem hiding this comment.
30 -> defaultReconciliationTimeout. Also I think waitAndAssert function should be usable here and provides better output.
cpuguy83
force-pushed
the
hacky_swarm_integration_tests
branch
2 times, most recently
from
eebeb57
to
e4f83a7
Compare
|
Updated |
|
@cpuguy83 Windows tests are failing because of missing build tags. |
aaronlehmann
added
the
status/failing-ci
cpuguy83
force-pushed
the
hacky_swarm_integration_tests
branch
from
e4f83a7
to
86c5bc1
Compare
This is done in a hacky way as currently there is no better way. Uses known implementation details about how tasks are scheduled to be able to operate on the underlying container. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
hacky_swarm_integration_tests
branch
from
86c5bc1
to
e5ec575
Compare
cpuguy83
removed
the
status/failing-ci
|
This is now 100% working and ready for review. |
|
LGTM |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done in a hacky way as currently there is no better way (that I know of).
Uses known implementation details about how tasks are scheduled to be
able to operate on the underlying container.
The one test I added is actually exposing a bug (fixed by #23947). Once this is merged we should add more tests to ensure that resulting containers match expectations from a service spec.
I've intentionally put these tests and related helpers into files with
_hack_in the name so once there is a better way, we can clean these up easily.I would be worried about releasing 1.12 without more tests like this.