Allow service and node filter to be name in tasks subcommands
#24173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on `docker node tasks` and `docker service tasks` commands. This changes is mainly server-side (between engine api and swarmkit). There is just a check in `api/client/service/tasks.go` to handle the special *self* meaning. Signed-off-by: Vincent Demeester <vincent@sbr.pm>
|
LGTM |
1 similar comment
|
LGTM |
|
don't merge yet! we're having issues with CI not being triggered, so it didn't run on this PR |
|
I think whole CI was run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow service and node filter to be name on
docker node tasksanddocker service taskscommands 🐅.This changes is mainly server-side (between engine api and swarmkit). There is just a check in
api/client/service/tasks.goto handle the special self meaning.This is an attempt to partly fix #24163 and #24165 (it just misses partial names, but this would require changes in
swarmkitI think 🐳).This is an alternative to a client-side only change (see master...vdemeester:tasks-filter-service-node-by-name).
/cc @aaronlehmann @cpuguy83 @stevvooe
🐸
Signed-off-by: Vincent Demeester vincent@sbr.pm