fix stdout and stderr in api client #24298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allencloud
force-pushed
the
fix-stdout-and-stderr-in-api-client
branch
from
87b7867
to
543a734
Compare
vdemeester
added
status/2-code-review
process/cherry-pick
and removed
status/0-triage
labels
|
LGTM 🐸 |
| @@ -33,7 +33,7 @@ func newConfigCommand(dockerCli *client.DockerCli) *cobra.Command { | |||
| } | |||
|
|
|||
| func runConfig(dockerCli *client.DockerCli, opts configOptions) error { | |||
| bundle, err := loadBundlefile(dockerCli.Err(), opts.namespace, opts.bundlefile) | |||
| bundle, err := loadBundlefile(dockerCli.Out(), opts.namespace, opts.bundlefile) | |||
There was a problem hiding this comment.
I think stderr is correct here. This output is logging, not "normal program output".
There was a problem hiding this comment.
For example, if someone is trying to get the output of the bundle into a file, they would direct stdout to a file, but then their will wouldn't be valid because this logging line would be included.
If it goes to stderr the file will be valid JSON.
|
It looks like |
allencloud
force-pushed
the
fix-stdout-and-stderr-in-api-client
branch
from
543a734
to
5c46f77
Compare
|
@dnephin Thanks. It is my miss in volume/remove.go. Really sorry. PR updated. |
|
LGTM |
allencloud
force-pushed
the
fix-stdout-and-stderr-in-api-client
branch
2 times, most recently
from
c0ac7e5
to
0859ad4
Compare
Signed-off-by: allencloud <allen.sun@daocloud.io>
allencloud
force-pushed
the
fix-stdout-and-stderr-in-api-client
branch
from
0859ad4
to
533bd82
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR did:
Write more specific code when dealing api client stdout and stderr:
dockerCli.Err();fmt.Println;Signed-off-by: allencloud allen.sun@daocloud.io