Don’t hold container lock for size calculation #31159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
|
Am somewhat the opposite of an expert in these matters, but what are the chances of failure to stop or remove containers due to "device is busy" due to a size determination in progress? Am thinking along the lines of the note about statfs and fstatfs here https://docs.docker.com/engine/admin/troubleshooting_volume_errors/. |
|
@trapier Layerstore has an internal reference counter for every layer. So when container is deleted in https://github.com/docker/docker/blob/91cffdbedb89e6164fe2ceca3d68ec039c1acc34/daemon/delete.go#L131 that function wouldn't actually delete the layer but only lower the reference count. When the size calculation completes and last reference is released the data is actually cleaned up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #31158
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com