Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bash completion for service constraints #31784

Merged

Conversation

albers
Copy link
Member

@albers albers commented Mar 13, 2017

  • Remove bash completion for service update --constraint (only exists for service create)
  • Add bash completion for service update --constraint-{add,rm}

- Remove bash completion for `service update --constraint`
- Add bash completion for `service update --constraint-{add,rm}`

Signed-off-by: Harald Albers <github@albersweb.de>
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@aaronlehmann
Copy link
Contributor

LGTM

@aaronlehmann aaronlehmann merged commit 47cd4bf into moby:master Mar 13, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.04.0 milestone Mar 13, 2017
@albers albers deleted the fix-completion-service-update-constraint branch March 13, 2017 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants