Update docker service constraint tab auto completion

[JoshkVFX]

- What I did
Altered the tab completion results for docker service update

- How I did it
Changed contrib/completion/bash/docker to reflect the new results

- How to verify it
Attempt a tab completion with a successfully built docker version

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[JoshkVFX]

Issue link here

Not sure if GordonTheTurtle's reply was automated or not, assuming it was but thanks either way. It's incredibly helpful

[thaJeztah]

This doesn't look right, because docker service create only has --constraint, not --constraint-add / --constraint-rm. The completion for that is done in the if [ "$subcommand" = "update" ] section; https://github.com/docker/docker/blob/1ecaed0a99331ff6140e0a714e1b50d466597775/contrib/completion/bash/docker#L3085-L3089

[thaJeztah]

Can you check if you have the latest version of the completion script installed on your machine? This completion works for me without this change

[JoshkVFX]

Damn, I appear to modified the wrong command.

Create already had the correct commands attached to it but I'm still getting the wrong autocompletion for update.

I believe I'm on the most up to date version but are there any extra steps I can take to test if I am on the right auto completion version?

[thaJeztah]

You can check the file in /usr/share/bash-completion/completions/docker, but based on the output of your docker version in the issue #32295 (comment), you have an older version of docker (1.12.6) installed, which did not have this as a completion; https://github.com/docker/docker/blob/v1.12.6/contrib/completion/bash/docker#L1755-L1761. The fix was added in #31784, which is part of the upcoming 17.04 release.

[thaJeztah]

Let me close this PR, because this issue is already fixed, but feel free to continue the discussion

[JoshkVFX]

Sorry about that, my fault for not properly checking things and getting ahead of myself.

Is there a specific spot where I can find up to date instructions on how to install and keep docker up to date? So far everyone has said not to use apt-get and use specific repositories but that one says I'm up to date.

[thaJeztah]

basically, if you add the right repository, you can either "pin" a specific version, or do apt-get update && apt-get install docker-ce, and you'll automatically get the latest version.

We recently switched to a different version scheme, and package names. Previously the package was named docker-engine, and now is called docker-ce (community edition), or docker-ee (enterprise edition, which is the paid-for version with professional support, SLA's etc)

The docker-engine package is still available on get.docker.com (bit-for-bit identical to the docker-ce package currently), and the new packages (docker-ce) are available on the download.docker.com apt/yum repository.

There's now two release channels; "edge" (a monthly release), and "stable" (released every 3 months, with a 4-month "support" for critical bugfixes and security issues).

To get just the "stable" updates, only enable the "stable" repository, and to get both "stable" and "edge" (monthly) updates, enable both repositories.

The installation instructions can be found here; https://docs.docker.com/engine/installation/linux/ubuntu/, and also mention removing "docker-engine" before installing "docker-ce" (although I think it goes automatically if you install the docker-ce package)

[JoshkVFX]

Awesome, thank you!