Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable docker search on private docker registry. #7495

Merged
merged 6 commits into from
Aug 20, 2014
Merged

Enable docker search on private docker registry. #7495

merged 6 commits into from
Aug 20, 2014

Conversation

sontags
Copy link
Contributor

@sontags sontags commented Aug 9, 2014

The cli interface works similar to other registry related commands:

docker search foo # ... searches for foo on the official hub
docker search localhost:5000/foo # ... does the same for the private reg at localhost:5000

Signed-off-by: Daniel Menet membership@sontags.ch

The cli interface works similar to other registry related commands:

  docker search foo

... searches for foo on the official hub

  docker search localhost:5000/foo

... does the same for the private reg at localhost:5000

Signed-off-by: Daniel Menet <membership@sontags.ch>
@sontags
Copy link
Contributor Author

sontags commented Aug 9, 2014

forgot to mention: this addresses issue #5061

Signed-off-by: Daniel Menet <membership@sontags.ch>
@crosbymichael
Copy link
Contributor

ping @shin- @dmp42

Can you review this PR please?

@dmp42
Copy link
Contributor

dmp42 commented Aug 13, 2014

LGTM - @shin- can you live test it and confirm?

@shin-
Copy link
Contributor

shin- commented Aug 15, 2014

$ curl -I localhost:5000/_ping
HTTP/1.1 200 OK
Server: gunicorn/18.0
Date: Fri, 15 Aug 2014 14:14:12 GMT
Connection: keep-alive
X-Docker-Registry-Standalone: True
Expires: -1
Content-Type: application/json
Pragma: no-cache
Cache-Control: no-cache
Content-Length: 4
X-Docker-Registry-Version: 0.7.3
X-Docker-Registry-Config: dev

shin@ubuntuvb:~/work/docker$ docker search localhost:5000/test
NAME                DESCRIPTION   STARS     OFFICIAL   AUTOMATED
library/testspeed                 0                    

LGTM!

@shin-
Copy link
Contributor

shin- commented Aug 15, 2014

@sontags Can you rebase? =)

vieux and others added 4 commits August 15, 2014 10:57
The cli interface works similar to other registry related commands:

  docker search foo

... searches for foo on the official hub

  docker search localhost:5000/foo

... does the same for the private reg at localhost:5000

Signed-off-by: Daniel Menet <membership@sontags.ch>
Signed-off-by: Daniel Menet <membership@sontags.ch>
Signed-off-by: Daniel Menet <membership@sontags.ch>
@sontags
Copy link
Contributor Author

sontags commented Aug 16, 2014

@shin- rebased

shin- added a commit that referenced this pull request Aug 20, 2014
Enable `docker search` on private docker registry.
@shin- shin- merged commit 2eb2699 into moby:master Aug 20, 2014
@shin-
Copy link
Contributor

shin- commented Aug 20, 2014

Thanks!

@sontags sontags deleted the enable_search_on_private_reg branch August 22, 2014 09:52
@parente
Copy link

parente commented Aug 24, 2014

With nginx proxying for a private registry and basic auth enabled, I'm getting 401s when trying to search. Should this include auth headers?

@shin-
Copy link
Contributor

shin- commented Aug 27, 2014

@parente Most certainly! Would you like to submit a patch? =)

@shin- shin- mentioned this pull request Aug 27, 2014
@shayke
Copy link

shayke commented Nov 18, 2014

Can you please guide me to the credentials headers? I'll try to submit a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants