bump Go to 1.4 #9615
bump Go to 1.4 #9615
Conversation
|
And if I understand correctly - docker binary became always dynamically linked with glibc. |
|
wait, @unclejack we don't want to bump yet, just to talk about it? |
|
@vbatts Yes, but this is better than opening an issue. |
|
understood |
|
/cc @therealprologic |
|
#9649 is about the issues we're seeing with errors like "database is locked" and "transaction in transaction" errors encountered when using Go 1.4 to build Docker. That is a major blocker for switching to Go 1.4. |
|
golang/go#9380 for reference |
| @@ -76,6 +76,9 @@ ENV DOCKER_CROSSPLATFORMS \ | |||
| ENV GOARM 5 | |||
| RUN cd /usr/local/go/src && bash -xc 'for platform in $DOCKER_CROSSPLATFORMS; do GOOS=${platform%/*} GOARCH=${platform##*/} ./make.bash --no-clean 2>&1; done' | |||
|
|
|||
| # reinstall standard library with netgo | |||
| RUN go clean -i net && go install -tags netgo std | |||
There was a problem hiding this comment.
I wish we could get something official telling us that this really is "the new official way" and that this isn't going to break on us in 1.5 or 1.6. 😢 (I guess that'd have to be in the form of an integration test upstream.)
There was a problem hiding this comment.
@tianon Do you want to open an issue on the Go repo?
There was a problem hiding this comment.
golang/go#9369 is an open discussion of netgo 👍
unclejack
force-pushed
the
bump_go_to_1.4
branch
from
e751584
to
80b0b99
Compare
|
@tiborvass rebased on master |
unclejack
force-pushed
the
bump_go_to_1.4
branch
from
80b0b99
to
d2a374b
Compare
|
This should be almost good to go now. There's only one failing test (the one with the tabs). |
|
@unclejack Yup, can we just swap this symbols to |
|
@LK4D4 You can send a PR against my branch if you'd like to do that. |
Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com>
Fixes moby#9449 Signed-off-by: Alexander Morozov <lk4d4@docker.com>
Signed-off-by: Alexander Morozov <lk4d4@docker.com>
unclejack
force-pushed
the
bump_go_to_1.4
branch
from
e339e99
to
a31c14c
Compare
|
LGTM |
|
LGTM |
|
Great job! |
|
ping @tianon sorry I thought you had LGTM... eeek :/ |
|
We haven't solved the |
|
Meaning: now we might merge PRs that have invalid syntax for Go 1.3 or otherwise have our CI complain about PRs that have perfect syntax but it's not Go 1.4 |
|
@tianon if we want so hard to have compat with 1.3, then we know place where syntax changed - empty range cycles. We can rewrite them to always use variable and place comment that this is for 1.3 compatibility. |
|
Main problem that now we have no cool travis version separation now :/ |
|
Hmm I bet we could make jenkins do that...? On Tue, Dec 23, 2014 at 9:06 AM, Alexander Morozov <notifications@github.com
|
|
@jfrazelle Yes, we can :) But if we will test only master, then there is chance that there will be broken commit in master. |
|
@LK4D4 yeah, that'll work, but the CI will still mark such PRs as invalid, and then we have to be manually diligent in checking for this |
|
@tianon There is no such code in docker now. So, I think it won't be to hard to trace it in future(it it will be something to trace) |
|
OK, fair enough |
This bumps the Go version to 1.4.
Please note that this version of Go breaks gosqlite and it also breaks mattn/go-sqlite3 when used with Docker.
This PR is also meant to be the place where we discuss everything related to this bump.