Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in HTTP proxy URL #13781

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Fix typo in HTTP proxy URL #13781

merged 1 commit into from
Nov 19, 2021

Conversation

mat007
Copy link
Member

@mat007 mat007 commented Nov 3, 2021

It’s HTTP here, not HTTPS. Besides the rest of the text has http://proxy.example.com:3128

Proposed changes

Unreleased project version (optional)

Related issues (optional)

It’s HTTP here, not HTTPS. Besides the rest of the text has `http://proxy.example.com:3128`
@netlify
Copy link

netlify bot commented Nov 3, 2021

✔️ Deploy Preview for docsdocker ready!

🔨 Explore the source changes: b3b2e4f

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsdocker/deploys/618294582a7dc70008f5e982

😎 Browse the preview: https://deploy-preview-13781--docsdocker.netlify.app

@djs55
Copy link
Contributor

djs55 commented Nov 3, 2021

There might be a capitalization problem as well:

PS >  docker run -e HTTP_PROXY=http://127.0.0.1:3128 alpine wget http://www.docker.com/
Connecting to www.docker.com (143.204.198.101:80)
Connecting to www.docker.com (143.204.198.101:443)
saving to 'index.html'
index.html           100% |********************************| 98.6k  0:00:00 ETA
'index.html' saved

PS >  docker run -e http_proxy=http://127.0.0.1:3128 alpine wget http://www.docker.com/
Connecting to 127.0.0.1:3128 (127.0.0.1:3128)
wget: can't connect to remote host (127.0.0.1): Connection refused

@mat007
Copy link
Member Author

mat007 commented Nov 3, 2021

There might be a capitalization problem as well:

It seems the docs are correct then? It’s HTTP_PROXY?
(Golang supports both but I think the Docker world mostly supports upper case, for some reason…)

@djs55
Copy link
Contributor

djs55 commented Nov 3, 2021

@mat007 I should have clarified: I wasn't running a proxy, so "Connection refused" was success :) wget ignored HTTP_PROXY but it respected http_proxy , so I suspect the "standard" capitalization is lower-case.

@mat007
Copy link
Member Author

mat007 commented Nov 3, 2021

Oh, right. I see what you mean now.
Yeah there is no real consensus on what the capitalization should be it seems , but if wget only knows about the lowercase version then indeed the example must use that.

I’ll amend, thanks!

@mat007
Copy link
Member Author

mat007 commented Nov 3, 2021

Oh wait, the docs actually never mention wget… 🤔

@usha-mandya
Copy link
Member

We also have #13786 from Sebastiaan on Proxy settings

Copy link
Member

@usha-mandya usha-mandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usha-mandya usha-mandya merged commit 0d0932d into master Nov 19, 2021
@usha-mandya usha-mandya deleted the mat007-patch-1 branch November 19, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants